[2/2] drm/ast: Drop fb_debug_enter/leave
diff mbox series

Message ID 20190612091253.26413-2-daniel.vetter@ffwll.ch
State New
Headers show
Series
  • [1/2] drm/omapdrm: drop fb_debug_enter/leave
Related show

Commit Message

Daniel Vetter June 12, 2019, 9:12 a.m. UTC
ast doesn't implement the mode_set_base_atomic hook this would need,
so this is dead code.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Sam Bobroff <sbobroff@linux.ibm.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/ast/ast_fb.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Thomas Zimmermann June 13, 2019, 6:45 a.m. UTC | #1
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

Am 12.06.19 um 11:12 schrieb Daniel Vetter:
> ast doesn't implement the mode_set_base_atomic hook this would need,
> so this is dead code.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Sam Bobroff <sbobroff@linux.ibm.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/gpu/drm/ast/ast_fb.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> index 05f45222b702..5480caecde86 100644
> --- a/drivers/gpu/drm/ast/ast_fb.c
> +++ b/drivers/gpu/drm/ast/ast_fb.c
> @@ -166,8 +166,6 @@ static struct fb_ops astfb_ops = {
>  	.fb_pan_display = drm_fb_helper_pan_display,
>  	.fb_blank = drm_fb_helper_blank,
>  	.fb_setcmap = drm_fb_helper_setcmap,
> -	.fb_debug_enter = drm_fb_helper_debug_enter,
> -	.fb_debug_leave = drm_fb_helper_debug_leave,
>  };
>  
>  static int astfb_create_object(struct ast_fbdev *afbdev,
>
Daniel Vetter June 13, 2019, 8:19 a.m. UTC | #2
On Thu, Jun 13, 2019 at 08:45:49AM +0200, Thomas Zimmermann wrote:
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks for taking a look, pushed to drm-misc-next.
-Daniel

> 
> Am 12.06.19 um 11:12 schrieb Daniel Vetter:
> > ast doesn't implement the mode_set_base_atomic hook this would need,
> > so this is dead code.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Dave Airlie <airlied@redhat.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: Sam Bobroff <sbobroff@linux.ibm.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: YueHaibing <yuehaibing@huawei.com>
> > ---
> >  drivers/gpu/drm/ast/ast_fb.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> > index 05f45222b702..5480caecde86 100644
> > --- a/drivers/gpu/drm/ast/ast_fb.c
> > +++ b/drivers/gpu/drm/ast/ast_fb.c
> > @@ -166,8 +166,6 @@ static struct fb_ops astfb_ops = {
> >  	.fb_pan_display = drm_fb_helper_pan_display,
> >  	.fb_blank = drm_fb_helper_blank,
> >  	.fb_setcmap = drm_fb_helper_setcmap,
> > -	.fb_debug_enter = drm_fb_helper_debug_enter,
> > -	.fb_debug_leave = drm_fb_helper_debug_leave,
> >  };
> >  
> >  static int astfb_create_object(struct ast_fbdev *afbdev,
> > 
> 
> -- 
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany
> GF: Felix Imend├Ârffer, Mary Higgins, Sri Rasiah
> HRB 21284 (AG N├╝rnberg)
>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index 05f45222b702..5480caecde86 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu/drm/ast/ast_fb.c
@@ -166,8 +166,6 @@  static struct fb_ops astfb_ops = {
 	.fb_pan_display = drm_fb_helper_pan_display,
 	.fb_blank = drm_fb_helper_blank,
 	.fb_setcmap = drm_fb_helper_setcmap,
-	.fb_debug_enter = drm_fb_helper_debug_enter,
-	.fb_debug_leave = drm_fb_helper_debug_leave,
 };
 
 static int astfb_create_object(struct ast_fbdev *afbdev,