| Message ID | 20190612124053.119182-1-me@myself5.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Andy Shevchenko |
| Headers | show |
| Series | platform/x86: touchscreen_dmi: Update Hi10 Air filter | expand |
On Wed, Jun 12, 2019 at 3:55 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi, > > On 12-06-19 14:40, Christian Oder wrote: > > Turns out the Hi10 Air is built by multiple companies so using Hampoo > > as a filter is not enough to cover all variants. > > > > This has been verified as working on the Hampoo and Morshow version. > > > > Signed-off-by: Christian Oder <me@myself5.de> > > Patch looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> By some reason patchwork doesn't have a trace of this. > > Regards, > > Hans > > > > --- > > drivers/platform/x86/touchscreen_dmi.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c > > index b662cb2d7cd5..61e7c4987d0d 100644 > > --- a/drivers/platform/x86/touchscreen_dmi.c > > +++ b/drivers/platform/x86/touchscreen_dmi.c > > @@ -597,7 +597,8 @@ static const struct dmi_system_id touchscreen_dmi_table[] = { > > /* Chuwi Hi10 Air */ > > .driver_data = (void *)&chuwi_hi10_air_data, > > .matches = { > > - DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"), > > + DMI_MATCH(DMI_SYS_VENDOR, "CHUWI INNOVATION AND TECHNOLOGY(SHENZHEN)CO.LTD"), > > + DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), > > DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"), > > }, > > }, > >
On Mon, Jun 17, 2019 at 3:37 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Wed, Jun 12, 2019 at 3:55 PM Hans de Goede <hdegoede@redhat.com> wrote: > > > > Hi, > > > > On 12-06-19 14:40, Christian Oder wrote: > > > Turns out the Hi10 Air is built by multiple companies so using Hampoo > > > as a filter is not enough to cover all variants. > > > > > > This has been verified as working on the Hampoo and Morshow version. > > > > > > Signed-off-by: Christian Oder <me@myself5.de> > > > > Patch looks good to me: > > > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > By some reason patchwork doesn't have a trace of this. I meant, Hans, your message, the patch itself is there.
Hi, On 17-06-19 14:38, Andy Shevchenko wrote: > On Mon, Jun 17, 2019 at 3:37 PM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: >> >> On Wed, Jun 12, 2019 at 3:55 PM Hans de Goede <hdegoede@redhat.com> wrote: >>> >>> Hi, >>> >>> On 12-06-19 14:40, Christian Oder wrote: >>>> Turns out the Hi10 Air is built by multiple companies so using Hampoo >>>> as a filter is not enough to cover all variants. >>>> >>>> This has been verified as working on the Hampoo and Morshow version. >>>> >>>> Signed-off-by: Christian Oder <me@myself5.de> >>> >>> Patch looks good to me: >>> >>> Reviewed-by: Hans de Goede <hdegoede@redhat.com> >> > >> By some reason patchwork doesn't have a trace of this. > > I meant, Hans, your message, the patch itself is there. Weird, no idea why this is happening. Regards, Hans
On Mon, Jun 17, 2019 at 3:52 PM Hans de Goede <hdegoede@redhat.com> wrote: > On 17-06-19 14:38, Andy Shevchenko wrote: > > On Mon, Jun 17, 2019 at 3:37 PM Andy Shevchenko > > <andy.shevchenko@gmail.com> wrote: > >> By some reason patchwork doesn't have a trace of this. > > I meant, Hans, your message, the patch itself is there. > > Weird, no idea why this is happening. For sake of testing, can you bounce the first message you sent here?
On Wed, Jun 12, 2019 at 3:55 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi, > > On 12-06-19 14:40, Christian Oder wrote: > > Turns out the Hi10 Air is built by multiple companies so using Hampoo > > as a filter is not enough to cover all variants. > > > > This has been verified as working on the Hampoo and Morshow version. > > > > Signed-off-by: Christian Oder <me@myself5.de> > > Patch looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > I have pushed it, though I forget about this issue, it went without this tag, sorry. > Regards, > > Hans > > > > --- > > drivers/platform/x86/touchscreen_dmi.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c > > index b662cb2d7cd5..61e7c4987d0d 100644 > > --- a/drivers/platform/x86/touchscreen_dmi.c > > +++ b/drivers/platform/x86/touchscreen_dmi.c > > @@ -597,7 +597,8 @@ static const struct dmi_system_id touchscreen_dmi_table[] = { > > /* Chuwi Hi10 Air */ > > .driver_data = (void *)&chuwi_hi10_air_data, > > .matches = { > > - DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"), > > + DMI_MATCH(DMI_SYS_VENDOR, "CHUWI INNOVATION AND TECHNOLOGY(SHENZHEN)CO.LTD"), > > + DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), > > DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"), > > }, > > }, > >
diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c index b662cb2d7cd5..61e7c4987d0d 100644 --- a/drivers/platform/x86/touchscreen_dmi.c +++ b/drivers/platform/x86/touchscreen_dmi.c @@ -597,7 +597,8 @@ static const struct dmi_system_id touchscreen_dmi_table[] = { /* Chuwi Hi10 Air */ .driver_data = (void *)&chuwi_hi10_air_data, .matches = { - DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"), + DMI_MATCH(DMI_SYS_VENDOR, "CHUWI INNOVATION AND TECHNOLOGY(SHENZHEN)CO.LTD"), + DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), DMI_MATCH(DMI_PRODUCT_SKU, "P1W6_C109D_B"), }, },
Turns out the Hi10 Air is built by multiple companies so using Hampoo as a filter is not enough to cover all variants. This has been verified as working on the Hampoo and Morshow version. Signed-off-by: Christian Oder <me@myself5.de> --- drivers/platform/x86/touchscreen_dmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)