| Message ID | 20190613101755.29740-1-kai.vehmanen@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ASoC: codec: hdac_hdmi: fix pin connections at cvt enable | expand |
On Thu, 13 Jun 2019 12:17:55 +0200, Kai Vehmanen wrote: > > +/** > + * Go through all converters and ensure connection is set to > + * the correct pin as set via kcontrols. > + */ Avoid using the double asterisks "/**" unless it's an entry for kernel-doc. > +static void hdac_hdmi_verify_connect_sel_all_pins(struct hdac_device *hdev) > +{ > + struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev); > + struct hdac_hdmi_port *port; > + struct hdac_hdmi_cvt *cvt; > + int cvt_idx = 0; > + > + list_for_each_entry(cvt, &hdmi->cvt_list, head) { > + port = hdac_hdmi_get_port_from_cvt(hdev, hdmi, cvt); > + if (port && port->pin) { > + snd_hdac_codec_write(hdev, port->pin->nid, 0, > + AC_VERB_SET_CONNECT_SEL, cvt_idx); > + dev_dbg(&hdev->dev, "%s: %s set connect %d -> %d\n", > + __func__, cvt->name, port->pin->nid, cvt_idx); Please fix indentation and use tabs. > + } > + ++cvt_idx; > + } > +} > + > /* > * This tries to get a valid pin and set the HW constraints based on the > * ELD. Even if a valid pin is not found return success so that device open > @@ -806,6 +829,14 @@ static int hdac_hdmi_cvt_output_widget_event(struct snd_soc_dapm_widget *w, > AC_VERB_SET_CHANNEL_STREAMID, pcm->stream_tag); > snd_hdac_codec_write(hdev, cvt->nid, 0, > AC_VERB_SET_STREAM_FORMAT, pcm->format); > + > + /** > + * The connection indices are shared by all converters and > + * may interfere with each other. Ensure correct > + * routing for all converters at stream start. > + */ Avoid the double-asterisks. thanks, Takashi
diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c index 660e0587f3999..702f17b36212f 100644 --- a/sound/soc/codecs/hdac_hdmi.c +++ b/sound/soc/codecs/hdac_hdmi.c @@ -546,6 +546,29 @@ static struct hdac_hdmi_port *hdac_hdmi_get_port_from_cvt( return NULL; } +/** + * Go through all converters and ensure connection is set to + * the correct pin as set via kcontrols. + */ +static void hdac_hdmi_verify_connect_sel_all_pins(struct hdac_device *hdev) +{ + struct hdac_hdmi_priv *hdmi = hdev_to_hdmi_priv(hdev); + struct hdac_hdmi_port *port; + struct hdac_hdmi_cvt *cvt; + int cvt_idx = 0; + + list_for_each_entry(cvt, &hdmi->cvt_list, head) { + port = hdac_hdmi_get_port_from_cvt(hdev, hdmi, cvt); + if (port && port->pin) { + snd_hdac_codec_write(hdev, port->pin->nid, 0, + AC_VERB_SET_CONNECT_SEL, cvt_idx); + dev_dbg(&hdev->dev, "%s: %s set connect %d -> %d\n", + __func__, cvt->name, port->pin->nid, cvt_idx); + } + ++cvt_idx; + } +} + /* * This tries to get a valid pin and set the HW constraints based on the * ELD. Even if a valid pin is not found return success so that device open @@ -806,6 +829,14 @@ static int hdac_hdmi_cvt_output_widget_event(struct snd_soc_dapm_widget *w, AC_VERB_SET_CHANNEL_STREAMID, pcm->stream_tag); snd_hdac_codec_write(hdev, cvt->nid, 0, AC_VERB_SET_STREAM_FORMAT, pcm->format); + + /** + * The connection indices are shared by all converters and + * may interfere with each other. Ensure correct + * routing for all converters at stream start. + */ + hdac_hdmi_verify_connect_sel_all_pins(hdev); + break; case SND_SOC_DAPM_POST_PMD:
In display codecs supported by hdac_hdmi, the connection indices are shared by all converters. At boot and resume from suspend, the connection state may be reset to default values. In case of multiple connected pins (multiple monitors connected with audio capability), routing and mute status of pins that are not connected to any PCM, may interfere with other pins. E.g. after resume from S3 with multiple monitors, unless all converters are in active use, playback to some PCMs may be muted due to the default settings of unrelated converters. Avoid this by ensuring all pin:cvt selections are correct in codec whenever a converter is enabled for playback. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> --- sound/soc/codecs/hdac_hdmi.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)