[03/15] libxl_pci: Make libxl__create_pci_backend static
diff mbox series

Message ID 20190614112444.29980-4-anthony.perard@citrix.com
State New
Headers show
Series
  • Some cleanup of libxl
Related show

Commit Message

Anthony PERARD June 14, 2019, 11:24 a.m. UTC
libxl__create_pci_backend isn't called from outside of libxl_pci
anymore, and it's only useful as part of the pci_add process, so
remove the prototype from libxl_internal.h.

No functional changes.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 tools/libxl/libxl_internal.h | 2 --
 tools/libxl/libxl_pci.c      | 4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)

Comments

Ian Jackson Sept. 17, 2019, 4:40 p.m. UTC | #1
Anthony PERARD writes ("[PATCH 03/15] libxl_pci: Make libxl__create_pci_backend static"):
> libxl__create_pci_backend isn't called from outside of libxl_pci
> anymore, and it's only useful as part of the pci_add process, so
> remove the prototype from libxl_internal.h.
> 
> No functional changes.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Patch
diff mbox series

diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index a25bacd7aa..01411382fd 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -1541,8 +1541,6 @@  _hidden int libxl__pci_topology_init(libxl__gc *gc,
 /* from libxl_pci */
 
 _hidden int libxl__device_pci_add(libxl__gc *gc, uint32_t domid, libxl_device_pci *pcidev, int starting);
-_hidden int libxl__create_pci_backend(libxl__gc *gc, uint32_t domid,
-                                      libxl_device_pci *pcidev, int num);
 _hidden int libxl__device_pci_destroy_all(libxl__gc *gc, uint32_t domid);
 _hidden bool libxl__is_igd_vga_passthru(libxl__gc *gc,
                                         const libxl_domain_config *d_config);
diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
index 67677d7b55..0e07f70f29 100644
--- a/tools/libxl/libxl_pci.c
+++ b/tools/libxl/libxl_pci.c
@@ -75,8 +75,8 @@  static void libxl__device_from_pcidev(libxl__gc *gc, uint32_t domid,
     device->kind = LIBXL__DEVICE_KIND_PCI;
 }
 
-int libxl__create_pci_backend(libxl__gc *gc, uint32_t domid,
-                              libxl_device_pci *pcidev, int num)
+static int libxl__create_pci_backend(libxl__gc *gc, uint32_t domid,
+                                     libxl_device_pci *pcidev, int num)
 {
     flexarray_t *front = NULL;
     flexarray_t *back = NULL;