diff mbox series

video: fbdev: s3c-fb: add COMPILE_TEST support

Message ID e771b89b-0e38-a712-b635-8d53cbf95a8e@samsung.com (mailing list archive)
State New, archived
Headers show
Series video: fbdev: s3c-fb: add COMPILE_TEST support | expand

Commit Message

Bartlomiej Zolnierkiewicz June 14, 2019, 2:46 p.m. UTC 
Add COMPILE_TEST support to s3c-fb driver for better compile
testing coverage.

Cc: Jingoo Han <jingoohan1@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
 drivers/video/fbdev/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Han Jingoo June 18, 2019, 6:12 a.m. UTC | #1 
On 6/14/19, 11:46 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> Add COMPILE_TEST support to s3c-fb driver for better compile
> testing coverage.
>
> Cc: Jingoo Han <jingoohan1@gmail.com>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
>  drivers/video/fbdev/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: b/drivers/video/fbdev/Kconfig
> ===================================================================
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1877,7 +1877,8 @@ config FB_TMIO_ACCELL
>  
>  config FB_S3C
>  	tristate "Samsung S3C framebuffer support"
> -	depends on FB && (CPU_S3C2416 || ARCH_S3C64XX)
> +	depends on FB && HAVE_CLK && HAS_IOMEM
> +	depends on (CPU_S3C2416 || ARCH_S3C64XX) || COMPILE_TEST
>  	select FB_CFB_FILLRECT
>  	select FB_CFB_COPYAREA
>  	select FB_CFB_IMAGEBLIT
Bartlomiej Zolnierkiewicz June 21, 2019, 11:08 a.m. UTC | #2 
On 6/18/19 8:12 AM, Jingoo Han wrote:
> On 6/14/19, 11:46 PM, Bartlomiej Zolnierkiewicz wrote:
>>
>> Add COMPILE_TEST support to s3c-fb driver for better compile
>> testing coverage.
>>
>> Cc: Jingoo Han <jingoohan1@gmail.com>
> Acked-by: Jingoo Han <jingoohan1@gmail.com>
>> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Thanks, I queued the patch for v5.3.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
diff mbox series

Patch

Index: b/drivers/video/fbdev/Kconfig
===================================================================
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1877,7 +1877,8 @@  config FB_TMIO_ACCELL
 
 config FB_S3C
 	tristate "Samsung S3C framebuffer support"
-	depends on FB && (CPU_S3C2416 || ARCH_S3C64XX)
+	depends on FB && HAVE_CLK && HAS_IOMEM
+	depends on (CPU_S3C2416 || ARCH_S3C64XX) || COMPILE_TEST
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT