| Message ID | 20190614154421.17556-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] firmware: ti_sci: remove set but not used variable 'dev' | expand |
On 6/14/19 10:44 AM, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_config: > drivers/firmware/ti_sci.c:2035:17: warning: variable dev set but not used [-Wunused-but-set-variable] > drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_get_config: > drivers/firmware/ti_sci.c:2104:17: warning: variable dev set but not used [-Wunused-but-set-variable] > drivers/firmware/ti_sci.c: In function ti_sci_cmd_rm_udmap_tx_ch_cfg: > drivers/firmware/ti_sci.c:2287:17: warning: variable dev set but not used [-Wunused-but-set-variable] > drivers/firmware/ti_sci.c: In function ti_sci_cmd_rm_udmap_rx_ch_cfg: > drivers/firmware/ti_sci.c:2357:17: warning: variable dev set but not used [-Wunused-but-set-variable] Thanks for the fix. > > It is never used since commit 1e407f337f40 ("firmware: > ti_sci: Add support for processor control") Warnings are actually introduced in commit 68608b5e5063 ("firmware: ti_sci: Add resource management APIs for ringacc, psi-l and udma"). While this patch fixes the warnings as well, I suggest to replace the dev_dbg/dev_err traces in these functions to use the dev variable instead of info->dev, to be consistent with the usage in the rest of the file. regards Suman > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/firmware/ti_sci.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c > index 86b2727..8c1a961 100644 > --- a/drivers/firmware/ti_sci.c > +++ b/drivers/firmware/ti_sci.c > @@ -2032,14 +2032,12 @@ static int ti_sci_cmd_ring_config(const struct ti_sci_handle *handle, > struct ti_sci_msg_hdr *resp; > struct ti_sci_xfer *xfer; > struct ti_sci_info *info; > - struct device *dev; > int ret = 0; > > if (IS_ERR_OR_NULL(handle)) > return -EINVAL; > > info = handle_to_ti_sci_info(handle); > - dev = info->dev; > > xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_RM_RING_CFG, > TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, > @@ -2101,14 +2099,12 @@ static int ti_sci_cmd_ring_get_config(const struct ti_sci_handle *handle, > struct ti_sci_msg_rm_ring_get_cfg_req *req; > struct ti_sci_xfer *xfer; > struct ti_sci_info *info; > - struct device *dev; > int ret = 0; > > if (IS_ERR_OR_NULL(handle)) > return -EINVAL; > > info = handle_to_ti_sci_info(handle); > - dev = info->dev; > > xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_RM_RING_GET_CFG, > TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, > @@ -2284,14 +2280,12 @@ static int ti_sci_cmd_rm_udmap_tx_ch_cfg(const struct ti_sci_handle *handle, > struct ti_sci_msg_hdr *resp; > struct ti_sci_xfer *xfer; > struct ti_sci_info *info; > - struct device *dev; > int ret = 0; > > if (IS_ERR_OR_NULL(handle)) > return -EINVAL; > > info = handle_to_ti_sci_info(handle); > - dev = info->dev; > > xfer = ti_sci_get_one_xfer(info, TISCI_MSG_RM_UDMAP_TX_CH_CFG, > TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, > @@ -2354,14 +2348,12 @@ static int ti_sci_cmd_rm_udmap_rx_ch_cfg(const struct ti_sci_handle *handle, > struct ti_sci_msg_hdr *resp; > struct ti_sci_xfer *xfer; > struct ti_sci_info *info; > - struct device *dev; > int ret = 0; > > if (IS_ERR_OR_NULL(handle)) > return -EINVAL; > > info = handle_to_ti_sci_info(handle); > - dev = info->dev; > > xfer = ti_sci_get_one_xfer(info, TISCI_MSG_RM_UDMAP_RX_CH_CFG, > TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, >
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c index 86b2727..8c1a961 100644 --- a/drivers/firmware/ti_sci.c +++ b/drivers/firmware/ti_sci.c @@ -2032,14 +2032,12 @@ static int ti_sci_cmd_ring_config(const struct ti_sci_handle *handle, struct ti_sci_msg_hdr *resp; struct ti_sci_xfer *xfer; struct ti_sci_info *info; - struct device *dev; int ret = 0; if (IS_ERR_OR_NULL(handle)) return -EINVAL; info = handle_to_ti_sci_info(handle); - dev = info->dev; xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_RM_RING_CFG, TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, @@ -2101,14 +2099,12 @@ static int ti_sci_cmd_ring_get_config(const struct ti_sci_handle *handle, struct ti_sci_msg_rm_ring_get_cfg_req *req; struct ti_sci_xfer *xfer; struct ti_sci_info *info; - struct device *dev; int ret = 0; if (IS_ERR_OR_NULL(handle)) return -EINVAL; info = handle_to_ti_sci_info(handle); - dev = info->dev; xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_RM_RING_GET_CFG, TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, @@ -2284,14 +2280,12 @@ static int ti_sci_cmd_rm_udmap_tx_ch_cfg(const struct ti_sci_handle *handle, struct ti_sci_msg_hdr *resp; struct ti_sci_xfer *xfer; struct ti_sci_info *info; - struct device *dev; int ret = 0; if (IS_ERR_OR_NULL(handle)) return -EINVAL; info = handle_to_ti_sci_info(handle); - dev = info->dev; xfer = ti_sci_get_one_xfer(info, TISCI_MSG_RM_UDMAP_TX_CH_CFG, TI_SCI_FLAG_REQ_ACK_ON_PROCESSED, @@ -2354,14 +2348,12 @@ static int ti_sci_cmd_rm_udmap_rx_ch_cfg(const struct ti_sci_handle *handle, struct ti_sci_msg_hdr *resp; struct ti_sci_xfer *xfer; struct ti_sci_info *info; - struct device *dev; int ret = 0; if (IS_ERR_OR_NULL(handle)) return -EINVAL; info = handle_to_ti_sci_info(handle); - dev = info->dev; xfer = ti_sci_get_one_xfer(info, TISCI_MSG_RM_UDMAP_RX_CH_CFG, TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
Fixes gcc '-Wunused-but-set-variable' warning: drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_config: drivers/firmware/ti_sci.c:2035:17: warning: variable dev set but not used [-Wunused-but-set-variable] drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_get_config: drivers/firmware/ti_sci.c:2104:17: warning: variable dev set but not used [-Wunused-but-set-variable] drivers/firmware/ti_sci.c: In function ti_sci_cmd_rm_udmap_tx_ch_cfg: drivers/firmware/ti_sci.c:2287:17: warning: variable dev set but not used [-Wunused-but-set-variable] drivers/firmware/ti_sci.c: In function ti_sci_cmd_rm_udmap_rx_ch_cfg: drivers/firmware/ti_sci.c:2357:17: warning: variable dev set but not used [-Wunused-but-set-variable] It is never used since commit 1e407f337f40 ("firmware: ti_sci: Add support for processor control") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/firmware/ti_sci.c | 8 -------- 1 file changed, 8 deletions(-)