From patchwork Fri Jun 14 20:35:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10996529 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 786D315E6 for ; Fri, 14 Jun 2019 20:36:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6B35728733 for ; Fri, 14 Jun 2019 20:36:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5F72E2876E; Fri, 14 Jun 2019 20:36:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2B4BE28733 for ; Fri, 14 Jun 2019 20:36:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 83C578938F; Fri, 14 Jun 2019 20:36:34 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 657108935A for ; Fri, 14 Jun 2019 20:36:32 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id s49so5286475edb.1 for ; Fri, 14 Jun 2019 13:36:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ozuYLkzuE5EKiRdXRtonyVrqpSQymWsQ+YHRXJTwCgs=; b=nUdNCsow1tp/jNHoALDsYwSOZknERmwSKEIzupG0ofsAuFOFm789eyURejXLZH0KH3 51DVmsuJ34PP9rgz8jZKkbBhJjbYgkclr3n//OQa2ttkaOLYIt7iI4R7ZbeIi+UXz9Xa rveMPyO3D3+7EFJpkPeICGkaJz7VfaQxTmOMesLAon6970hIeQoFLJCdhj9BC7D4qOVr M1jBd5XXRMyXJIeM140U/UDOrX02jFNum4vDh4RABqV6JdIbrQNgwuNvyf84+SQrc6B/ DOiz7REEtInqzKlu5T8S+dIE73nhN8LD0w0Zf0iIrhgrmRYRAZB7gke8C66KjeuqLKBK 9Eiw== X-Gm-Message-State: APjAAAWEpaftRL0UFy+yomcT2jsf9nW5/sWdMRsqAXR4GAj10nH8elT6 no+kSPb8PXsRxCt+D8pHFogfLc8sUVQ= X-Google-Smtp-Source: APXvYqxmo68l9VKjRmngxSrKRMzF9noCB0RAXjDyt/6YJA3Pw4xvMLAa618hUD4JDSKybWUZoFjsCw== X-Received: by 2002:a17:906:bb11:: with SMTP id jz17mr15709119ejb.185.1560544590304; Fri, 14 Jun 2019 13:36:30 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id n15sm1166672edd.49.2019.06.14.13.36.29 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 14 Jun 2019 13:36:29 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 08/59] drm/omapdrm: drop fb_debug_enter/leave Date: Fri, 14 Jun 2019 22:35:24 +0200 Message-Id: <20190614203615.12639-9-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190614203615.12639-1-daniel.vetter@ffwll.ch> References: <20190614203615.12639-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ozuYLkzuE5EKiRdXRtonyVrqpSQymWsQ+YHRXJTwCgs=; b=dlEupAw2H2UeKPz87OmFUI9OX5pfxKv+9CxXEZ0H764h+0dwq/RRP4E1dSxIaGiyTX Rl8DiP0ig24M/9fSJoSFelZyoCtIujHG6qbmHeExrleSBnOng7C6Y/BoE6a376ueGtgU pQiEdJtMvZcUlwPggQ1u+8mJXaAmF1/ER3C2g= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Tomi Valkeinen , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP This is a no-op on atomic drivers because with atomic it's simply too complicated to get all the locking and workers and nonblocking synchronization correct, from essentially an NMI context. Well, too complicated = impossible. Also, omapdrm never implemented the mode_set_base_atomic hook, so I kinda wonder why this was ever added. Drop the hooks. Signed-off-by: Daniel Vetter Cc: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c index 50aabd854f4d..0dad42e819ba 100644 --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c @@ -87,8 +87,6 @@ static struct fb_ops omap_fb_ops = { .fb_setcmap = drm_fb_helper_setcmap, .fb_blank = drm_fb_helper_blank, .fb_pan_display = omap_fbdev_pan_display, - .fb_debug_enter = drm_fb_helper_debug_enter, - .fb_debug_leave = drm_fb_helper_debug_leave, .fb_ioctl = drm_fb_helper_ioctl, .fb_read = drm_fb_helper_sys_read,