From patchwork Fri Jun 14 20:36:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10996777 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ECFAD14E5 for ; Fri, 14 Jun 2019 20:39:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF5F628733 for ; Fri, 14 Jun 2019 20:39:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D3D9B2876B; Fri, 14 Jun 2019 20:39:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8D71B28733 for ; Fri, 14 Jun 2019 20:39:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C66DE897DC; Fri, 14 Jun 2019 20:37:47 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDB1289870 for ; Fri, 14 Jun 2019 20:37:28 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id p26so5271146edr.2 for ; Fri, 14 Jun 2019 13:37:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yvL73GVoINdhNnVubpUzKj2ETKHlC4lNPOPbS+G8PA4=; b=sw9VoMNEctTuhnVJHZ0B3CqtqL41Uv/JcaTsBe4jSKShmQT1xExiSNxJrLKYqqKaJo 0DzLhe6AkVaCneOq2oxdJQIa0aK1AM/j5jq/8bZxmsfNRpaSGIDU6RjCAvWf033k/8+n XhDGKESB+w7X7Ss70Qca1ckUNDoM0yy8heZq5JCe1RamlKhRP9hIEWFrosiXU01F5xUl 0WpBMX7UrkPBayzauNeOwvdzWWFEb+AfAEJsZFIhlPIqmKQ+SuALBW1Ka355HnPn4Iau 1xw8j2QgOdfx3Y8x0QCylGdqM+ntfD2CLp3aOwDuvXavFvqgrrPdc01Q4qNzp28zCWil 8q8w== X-Gm-Message-State: APjAAAWGqRyxXjBD+T/DLI6M7QVzIsRbmcBkr7+mZi3ttJRI5ffVWQTu VLyE18x+rozr5j4ECMoONi+LXV4OQmo= X-Google-Smtp-Source: APXvYqwSY79Sms9DZAgKAJOgx/nmLKjgpZQTSZB/8wAoym31pj4WLJyiXKSRlom4fGdypB6cDmeQuQ== X-Received: by 2002:a50:9590:: with SMTP id w16mr82163394eda.0.1560544646005; Fri, 14 Jun 2019 13:37:26 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id n15sm1166672edd.49.2019.06.14.13.37.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 14 Jun 2019 13:37:25 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 56/59] drm/todo: Update backlight todo Date: Fri, 14 Jun 2019 22:36:12 +0200 Message-Id: <20190614203615.12639-57-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190614203615.12639-1-daniel.vetter@ffwll.ch> References: <20190614203615.12639-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yvL73GVoINdhNnVubpUzKj2ETKHlC4lNPOPbS+G8PA4=; b=c68BIYb/kJ1Fo6CXnbHp0PIOLUtEi7PtlwBUIDG5mvas37o9bExx14AGL3oNxu1Dmo voZQOH3fzYQ4IeUgZnVZVTFuSwV3zC5qZIlXtSYvXsIStFyog9Z6SkuhyuJgmhv0lpH1 L/X2DCDrhLYPNSZrAfE/42ay/loNfCq32/6ho= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Basic helpers have been extracted, now there's a pile more todo still across the entire tree. Signed-off-by: Daniel Vetter Acked-by: Sam Ravnborg Reviewed-by: Daniel Thompson --- Documentation/gpu/todo.rst | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 21a7b7800d3e..c4e7c0672a14 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -422,6 +422,19 @@ fit the available time. Contact: Daniel Vetter +Backlight Refactoring +--------------------- + +Backlight drivers have a triple enable/disable state, which is a bit overkill. +Plan to fix this: + +1. Roll out backlight_enable() and backlight_disable() helpers everywhere. This + has started already. +2. In all, only look at one of the three status bits set by the above helpers. +3. Remove the other two status bits. + +Contact: Daniel Vetter + Driver Specific =============== @@ -431,20 +444,6 @@ tinydrm Tinydrm is the helper driver for really simple fb drivers. The goal is to make those drivers as simple as possible, so lots of room for refactoring: -- backlight helpers, probably best to put them into a new drm_backlight.c. - This is because drivers/video is de-facto unmaintained. We could also - move drivers/video/backlight to drivers/gpu/backlight and take it all - over within drm-misc, but that's more work. Backlight helpers require a fair - bit of reworking and refactoring. A simple example is the enabling of a backlight. - Tinydrm has helpers for this. It would be good if other drivers can also use the - helper. However, there are various cases we need to consider i.e different - drivers seem to have different ways of enabling/disabling a backlight. - We also need to consider the backlight drivers (like gpio_backlight). The situation - is further complicated by the fact that the backlight is tied to fbdev - via fb_notifier_callback() which has complicated logic. For further details, refer - to the following discussion thread: - https://groups.google.com/forum/#!topic/outreachy-kernel/8rBe30lwtdA - - spi helpers, probably best put into spi core/helper code. Thierry said the spi maintainer is fast&reactive, so shouldn't be a big issue.