diff mbox series

counter: fix ftm-quaddec build error on UML

Message ID e33254e5-3e8e-fc86-de72-b3dd2f6c310c@infradead.org (mailing list archive)
State New, archived
Headers show
Series counter: fix ftm-quaddec build error on UML | expand

Commit Message

Randy Dunlap June 17, 2019, 4:21 p.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Fix build error on user-mode Linux, which does not set HAS_IOMEM,
so devm_ioremap() is not available.  Fixes this build error:

ERROR: "devm_ioremap" [drivers/counter/ftm-quaddec.ko] undefined!

Fixes: a3b9a99980d9 ("counter: add FlexTimer Module Quadrature decoder counter driver")

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kjeld Flarup <kfa@deif.com>
Cc: Patrick Havelange <patrick.havelange@essensium.com>
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: linux-iio@vger.kernel.org
---
BTW, please fix these lines to have ending '>' characters:
MODULE_AUTHOR("Kjeld Flarup <kfa@deif.com");
MODULE_AUTHOR("Patrick Havelange <patrick.havelange@essensium.com");

 drivers/counter/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Richard Weinberger June 17, 2019, 7:54 p.m. UTC | #1 
Hi!

----- Ursprüngliche Mail -----
> Von: "Randy Dunlap" <rdunlap@infradead.org>
> An: "linux-kernel" <linux-kernel@vger.kernel.org>, linux-iio@vger.kernel.org
> CC: "Geert Uytterhoeven" <geert@linux-m68k.org>, "Kjeld Flarup" <kfa@deif.com>, "Patrick Havelange"
> <patrick.havelange@essensium.com>, "William Breathitt Gray" <vilhelm.gray@gmail.com>, "richard" <richard@nod.at>
> Gesendet: Montag, 17. Juni 2019 18:21:40
> Betreff: [PATCH] counter: fix ftm-quaddec build error on UML

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build error on user-mode Linux, which does not set HAS_IOMEM,
> so devm_ioremap() is not available.  Fixes this build error:
> 
> ERROR: "devm_ioremap" [drivers/counter/ftm-quaddec.ko] undefined!
> 
> Fixes: a3b9a99980d9 ("counter: add FlexTimer Module Quadrature decoder counter
> driver")
> 
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

AFAICT Patrick fixed this already.

Thanks,
//richard
William Breathitt Gray June 18, 2019, 5:21 a.m. UTC | #2 
On Mon, Jun 17, 2019 at 09:54:45PM +0200, Richard Weinberger wrote:
> Hi!
> 
> ----- Ursprüngliche Mail -----
> > Von: "Randy Dunlap" <rdunlap@infradead.org>
> > An: "linux-kernel" <linux-kernel@vger.kernel.org>, linux-iio@vger.kernel.org
> > CC: "Geert Uytterhoeven" <geert@linux-m68k.org>, "Kjeld Flarup" <kfa@deif.com>, "Patrick Havelange"
> > <patrick.havelange@essensium.com>, "William Breathitt Gray" <vilhelm.gray@gmail.com>, "richard" <richard@nod.at>
> > Gesendet: Montag, 17. Juni 2019 18:21:40
> > Betreff: [PATCH] counter: fix ftm-quaddec build error on UML
> 
> > From: Randy Dunlap <rdunlap@infradead.org>
> > 
> > Fix build error on user-mode Linux, which does not set HAS_IOMEM,
> > so devm_ioremap() is not available.  Fixes this build error:
> > 
> > ERROR: "devm_ioremap" [drivers/counter/ftm-quaddec.ko] undefined!
> > 
> > Fixes: a3b9a99980d9 ("counter: add FlexTimer Module Quadrature decoder counter
> > driver")
> > 
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> 
> AFAICT Patrick fixed this already.
> 
> Thanks,
> //richard

Yes, commit 0c75376fa395 ("counter/ftm-quaddec: Add missing dependencies
in Kconfig") in Greg KH's staging repository in the staging-linus
branch should address this issue.

William Breathitt Gray
diff mbox series

Patch

--- lnx-52-rc5.orig/drivers/counter/Kconfig
+++ lnx-52-rc5/drivers/counter/Kconfig
@@ -51,6 +51,7 @@  config STM32_LPTIMER_CNT
 
 config FTM_QUADDEC
 	tristate "Flex Timer Module Quadrature decoder driver"
+	depends on HAS_IOMEM
 	help
 	  Select this option to enable the Flex Timer Quadrature decoder
 	  driver.