| Message ID | 1560843541-11611-1-git-send-email-dingxiang@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Arm: zx: remove redundant dev_err message | expand |
On Tue, Jun 18, 2019 at 03:39:01PM +0800, Ding Xiang wrote: > devm_ioremap_resource already contains error message, so remove > the redundant dev_err message > > Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com> Acked-by: Shawn Guo <shawnguo@kernel.org> Arnd, Olof, Can you please apply it to arm-soc tree? Thanks. Shawn > --- > arch/arm/mach-zx/zx296702-pm-domain.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c > index 7a08bf9d..ac44ea8 100644 > --- a/arch/arm/mach-zx/zx296702-pm-domain.c > +++ b/arch/arm/mach-zx/zx296702-pm-domain.c > @@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev) > } > > pcubase = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(pcubase)) { > - dev_err(&pdev->dev, "ioremap fail.\n"); > + if (IS_ERR(pcubase)) > return -EIO; > - } > > for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i) > pm_genpd_init(zx296702_pm_domains[i], NULL, false); > -- > 1.9.1 > > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, Jun 18, 2019 at 09:46:36PM +0800, Shawn Guo wrote: > On Tue, Jun 18, 2019 at 03:39:01PM +0800, Ding Xiang wrote: > > devm_ioremap_resource already contains error message, so remove > > the redundant dev_err message > > > > Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com> > > Acked-by: Shawn Guo <shawnguo@kernel.org> > > Arnd, Olof, > > Can you please apply it to arm-soc tree? Thanks. > > Shawn > > > --- > > arch/arm/mach-zx/zx296702-pm-domain.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c > > index 7a08bf9d..ac44ea8 100644 > > --- a/arch/arm/mach-zx/zx296702-pm-domain.c > > +++ b/arch/arm/mach-zx/zx296702-pm-domain.c > > @@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev) > > } > > > > pcubase = devm_ioremap_resource(&pdev->dev, res); > > - if (IS_ERR(pcubase)) { > > - dev_err(&pdev->dev, "ioremap fail.\n"); > > + if (IS_ERR(pcubase)) > > return -EIO; Shouldn't the error return also get fixed? > > - } > > > > for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i) > > pm_genpd_init(zx296702_pm_domains[i], NULL, false); > > -- > > 1.9.1 > > > > > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c index 7a08bf9d..ac44ea8 100644 --- a/arch/arm/mach-zx/zx296702-pm-domain.c +++ b/arch/arm/mach-zx/zx296702-pm-domain.c @@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev) } pcubase = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(pcubase)) { - dev_err(&pdev->dev, "ioremap fail.\n"); + if (IS_ERR(pcubase)) return -EIO; - } for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i) pm_genpd_init(zx296702_pm_domains[i], NULL, false);
devm_ioremap_resource already contains error message, so remove the redundant dev_err message Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com> --- arch/arm/mach-zx/zx296702-pm-domain.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)