From patchwork Tue Jun 18 10:20:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tetsuo Handa X-Patchwork-Id: 11001367 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 586621932 for ; Tue, 18 Jun 2019 10:21:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 48B55288DA for ; Tue, 18 Jun 2019 10:21:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3D35228A2D; Tue, 18 Jun 2019 10:21:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EF48288DA for ; Tue, 18 Jun 2019 10:21:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52E986B0003; Tue, 18 Jun 2019 06:21:47 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 4DF228E0002; Tue, 18 Jun 2019 06:21:47 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A7C88E0001; Tue, 18 Jun 2019 06:21:47 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by kanga.kvack.org (Postfix) with ESMTP id 1A1B86B0003 for ; Tue, 18 Jun 2019 06:21:47 -0400 (EDT) Received: by mail-io1-f71.google.com with SMTP id y5so15615618ioj.10 for ; Tue, 18 Jun 2019 03:21:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id; bh=0zuk9ap3kdii5bGymjz3VhOYqS2Fp0WNvD9SwPrFQ54=; b=rmr4qhHBETeKAl133JEG9Gy6aWZESVg4d10r6mv8nwQWbAj5bMCGq9JlElrUjXaut1 nRTm3GXPQCNsvOt2y+kuE5A7x6T6irOSDlh9LT0L8tMs2/dIXD5gNQOq7ZFvkxucbH4N ajlvec6f5H3qlUE/n8/Gp2iH6MJXNJjh/6Gkf1bIbXwTnFlT35IcvSN+9ejWTGbRTyGq 4IXrTlf/yvm/ZCzW1ijsFbeE4IxN/MQ9pPZUX9HeBJgRfB9ZLHauqBoggFAhwrCpU+e/ yxY+629n1CYhMei9wYA0d8K6JRKJWwmIRRYFqqfciAbwBglNVS/slCBdKsoyzDIQFL1w GKsw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of penguin-kernel@i-love.sakura.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@i-love.sakura.ne.jp X-Gm-Message-State: APjAAAVO3Fb3OnabO6wgUQubpq6qgsw2cyfRsflBAbwIhiwpU8JSxqR7 +FlCRG27Iv+X8iAC0YR6uFYMIupyuiDBTqQY0AFYJZbnvNLOVl7yy8X3Qk+mg7D2fp1LJAhvfUo p8YNchtr2ojq4dUr74vcjjta0W7A68+4gLka/JXCx2mYNaRC4LXzyH6YrBg1lPtRBCA== X-Received: by 2002:a5d:9047:: with SMTP id v7mr60892404ioq.18.1560853306878; Tue, 18 Jun 2019 03:21:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqz1ozq2rr1R2QTsE0S0KHX0UZzr/VCosEKAQFDUG+va/2/UquFgTeCAMyMl+C6cknQF7adw X-Received: by 2002:a5d:9047:: with SMTP id v7mr60892253ioq.18.1560853304532; Tue, 18 Jun 2019 03:21:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560853304; cv=none; d=google.com; s=arc-20160816; b=fkkzLfA68tsYjFMCv4mt/+z9JV9yBGBwIBRlXw1lXiQoYz/4FI96Id0C/neSbE0cUw 0lqhHkpFzFt0uRF0phbFkU8AbcxRFJmXecVohJofH07I9G/WXfmhecqch4QsfGhrlnf7 sO5AAv4+UESdTtDHajdL6gu/jp4O89hK1om+oesFbEjKsHW0vTqhYXEb2vBRfpvrdvfX n6nIPuvmMaxEQ56Ta49biaGVK+MlrfmAUxQu504CdJIo7l4gSle/m6BveUUwd7cRwOB9 MTveXS/XyMqm2XIoshq10bN7dQc7dnBiCB46Ew3I+lTUdsfSbblSHY2m/54dC4pt4WsU r2aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from; bh=0zuk9ap3kdii5bGymjz3VhOYqS2Fp0WNvD9SwPrFQ54=; b=KOkMjhJkH0baA/P/VZRPf/cmNDpk6WqHLrrHBszMNpGbGG17MI5vEmICUyfjQZ766P sBxPZmPLqUkZGd2tUgygQFVLVKa82PqRoEHM+xnHoJArX3sPqxEi2viWYdtBLPbXc/RG OVZTNGctF04yL+9uGRgQ6DgUc52Gg7br5kFc97r1ADzINMibAkSKjYI3R1/n204Tx4Yh Mrf55lx8aU3Dphetpd9Q5QNQcS9H5NkXlQAZLuKoETG9mYe3P1ZQohY6MwZMtSGCDwlQ a70pmDoV9yx7QfzqTLUWc1HjsfB5fs/roYYmO1Z9ToGE59TefQIjZB7dJsmztpJiJMtt gU1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of penguin-kernel@i-love.sakura.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@i-love.sakura.ne.jp Received: from www262.sakura.ne.jp (www262.sakura.ne.jp. [202.181.97.72]) by mx.google.com with ESMTPS id m18si11065510jaa.95.2019.06.18.03.21.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jun 2019 03:21:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of penguin-kernel@i-love.sakura.ne.jp designates 202.181.97.72 as permitted sender) client-ip=202.181.97.72; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of penguin-kernel@i-love.sakura.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@i-love.sakura.ne.jp Received: from fsav101.sakura.ne.jp (fsav101.sakura.ne.jp [27.133.134.228]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id x5IALFcr066488; Tue, 18 Jun 2019 19:21:15 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav101.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav101.sakura.ne.jp); Tue, 18 Jun 2019 19:21:15 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav101.sakura.ne.jp) Received: from ccsecurity.localdomain (softbank126012062002.bbtec.net [126.12.62.2]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id x5IALA0K066330 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 18 Jun 2019 19:21:15 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) From: Tetsuo Handa To: Andrew Morton Cc: linux-mm@kvack.org, Tetsuo Handa , David Rientjes , Greg Thelen , Johannes Weiner , KAMEZAWA Hiroyuki , Michal Hocko Subject: [PATCH] mm: oom: Remove thread group leader check in oom_evaluate_task(). Date: Tue, 18 Jun 2019 19:20:57 +0900 Message-Id: <1560853257-14934-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> X-Mailer: git-send-email 1.8.3.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Since mem_cgroup_scan_tasks() uses CSS_TASK_ITER_PROCS, only thread group leaders will be scanned (unless dying leaders with live threads). Thus, commit d49ad9355420c743 ("mm, oom: prefer thread group leaders for display purposes") makes little sense. Signed-off-by: Tetsuo Handa Cc: David Rientjes Cc: Johannes Weiner Cc: Michal Hocko Cc: KAMEZAWA Hiroyuki Cc: Greg Thelen --- mm/oom_kill.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 32abc7a..09a5116 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -348,9 +348,6 @@ static int oom_evaluate_task(struct task_struct *task, void *arg) if (!points || points < oc->chosen_points) goto next; - /* Prefer thread group leaders for display purposes */ - if (points == oc->chosen_points && thread_group_leader(oc->chosen)) - goto next; select: if (oc->chosen) put_task_struct(oc->chosen);