[08/17] msvc: define O_ACCMODE

Message ID	b23651a357db822aabb0b2e65dc962829a117645.1560860634.git.gitgitgadget@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@kernel.org> Date: Tue, 18 Jun 2019 05:24:01 -0700 (PDT) Message-Id: <b23651a357db822aabb0b2e65dc962829a117645.1560860634.git.gitgitgadget@gmail.com> In-Reply-To: <pull.149.git.gitgitgadget@gmail.com> References: <pull.149.git.gitgitgadget@gmail.com> From: "Philip Oakley via GitGitGadget" <gitgitgadget@gmail.com> Subject: [PATCH 08/17] msvc: define O_ACCMODE Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano <gitster@pobox.com>, Philip Oakley <philipoakley@iee.org> Sender: git-owner@vger.kernel.org Precedence: bulk
Series	Fix MSVC support, at long last \| expand [00/17] Fix MSVC support, at long last [02/17] t0001 (mingw): do not expect a specific order of stdout/stderr [03/17] cache-tree.c: avoid reusing the DEBUG constant [04/17] obstack: fix compiler warning [05/17] mingw: replace mingw_startup() hack [06/17] msvc: fix dependencies of compat/msvc.c [07/17] msvc: include sigset_t definition [08/17] msvc: define O_ACCMODE [09/17] msvc: mark a variable as non-const [10/17] msvc: do not re-declare the timespec struct [11/17] msvc: define ftello() [12/17] msvc: fix detect_msys_tty() [13/17] msvc: support building Git using MS Visual C++ [14/17] msvc: add pragmas for common warnings [15/17] msvc: do not pretend to support all signals [16/17] msvc: avoid debug assertion windows in Debug Mode [17/17] msvc: ignore .dll and incremental compile output

Message ID

b23651a357db822aabb0b2e65dc962829a117645.1560860634.git.gitgitgadget@gmail.com (mailing list archive)

State

New, archived

Headers

Date: Tue, 18 Jun 2019 05:24:01 -0700 (PDT)
Message-Id: 
 <b23651a357db822aabb0b2e65dc962829a117645.1560860634.git.gitgitgadget@gmail.com>
In-Reply-To: <pull.149.git.gitgitgadget@gmail.com>
References: <pull.149.git.gitgitgadget@gmail.com>
From: "Philip Oakley via GitGitGadget" <gitgitgadget@gmail.com>
Subject: [PATCH 08/17] msvc: define O_ACCMODE
Fcc: Sent
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
        Philip Oakley <philipoakley@iee.org>
Sender: git-owner@vger.kernel.org
Precedence: bulk

Series

Fix MSVC support, at long last | expand

Commit Message

Linus Arver via GitGitGadget June 18, 2019, 12:24 p.m. UTC

From: Philip Oakley <philipoakley@iee.org>

This constant is not defined in MSVC's headers.

In UCRT's fcntl.h, _O_RDONLY, _O_WRONLY and _O_RDWR are defined as 0, 1
and 2, respectively. Yes, that means that UCRT breaks with the tradition
that O_RDWR == O_RDONLY | O_WRONLY.

It is a perfectly legal way to define those constants, though, therefore
we need to take care of defining O_ACCMODE accordingly.

This is particularly important in order to keep our "open() can set
errno to EISDIR" emulation working: it tests that (flags & O_ACCMODE) is
not identical to O_RDONLY before going on to test specifically whether
the file for which open() reported EACCES is, in fact, a directory.

Signed-off-by: Philip Oakley <philipoakley@iee.org>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 compat/msvc.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/compat/msvc.h b/compat/msvc.h
index 04b4750b87..d336d80670 100644
--- a/compat/msvc.h
+++ b/compat/msvc.h
@@ -19,6 +19,8 @@ 
 #undef ERROR
 
 typedef int sigset_t;
+/* open for reading, writing, or both (not in fcntl.h) */
+#define O_ACCMODE     (_O_RDONLY | _O_WRONLY | _O_RDWR)
 
 #include "compat/mingw.h"

[08/17] msvc: define O_ACCMODE

Commit Message

Patch