From patchwork Tue Jun 18 14:02:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11001785 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 95F2A14BB for ; Tue, 18 Jun 2019 14:02:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 864B028B21 for ; Tue, 18 Jun 2019 14:02:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7A97328B27; Tue, 18 Jun 2019 14:02:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1117C28B36 for ; Tue, 18 Jun 2019 14:02:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 67CAA6E17B; Tue, 18 Jun 2019 14:02:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A3066E17B for ; Tue, 18 Jun 2019 14:02:49 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id k8so21894924eds.7 for ; Tue, 18 Jun 2019 07:02:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=msqCONNV1H08SzrVEOsCbMPoul6NP4oR7dk8Qo7oJqU=; b=nlJt2Bzd8NSpqhce88tLP6Hlvlo8C9nkVyIIGKx+v/FMPkOGLvfw2hbC7LO5dXBaGm blQxxUj9eVgRQXWaM1g8nL4B222P4tpTcVZB1YlF89M6GSEgGvFWYvTEhMl/moT7zs7D FzJ1lW78u3Hfhs5uiLHq+y7FQkwnE5jQGsAjT5q04GBLvjVnXisF4XMZOtHkK1eojGnP rTf2MFzN4F1aZgW/xejfjITurX9eZoHauKoE0uZLD6WS6pWlYmJ5fTDef2kmCAkq3TyA yCpf+S4fG8NJA6DC6qzT4ghep4T3PuUIQ7O1nxs32ZW1JA3FU5MG+LlmOtqgzx9MzyPO MUjg== X-Gm-Message-State: APjAAAVlNk9plrKadeF25c1CH5Nun2VzAEPilSvI8QAJ+Vaj5Z5uoa+M a0EFB/MaN2URCu83ml28R1vb3w== X-Google-Smtp-Source: APXvYqx28PSLe0JmJswHjHtdURCJc9m9CQMxBbNGmo/Dphhd1Pkgm6ONKApQIst4FdOBXZJa631WYA== X-Received: by 2002:a50:8ba6:: with SMTP id m35mr66691549edm.199.1560866567893; Tue, 18 Jun 2019 07:02:47 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id 30sm435738eji.5.2019.06.18.07.02.46 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 18 Jun 2019 07:02:47 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development Subject: [PATCH] drm/todo: Update drm_gem_object_funcs todo even more Date: Tue, 18 Jun 2019 16:02:41 +0200 Message-Id: <20190618140241.19856-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190614203615.12639-2-daniel.vetter@ffwll.ch> References: <20190614203615.12639-2-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=msqCONNV1H08SzrVEOsCbMPoul6NP4oR7dk8Qo7oJqU=; b=lAHldTeCLKjylpzvno55ytHkH6yySrYHfW2AGDJh2XJfCGPZ39jLx0f3lJdyjJpSdd BUf4L3POMsBfkcyGOhIkZo1lQdnAvnzx68lp8YsD6aZgoFlk72+uBhGAbbVURsc2jJ7I P9aPOUhMqnBfO5mZsVfTTDpAqpuW6u5A43cvU= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , David Airlie , Daniel Vetter , DRI Development , Maxime Ripard , Gerd Hoffmann , Greg Kroah-Hartman , Daniel Vetter , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP I rushed merging this a bit too much, and Noralf pointed out that we're a lot better already and have made great progress. Let's try again. Fixes: 42dbbb4b54a3 ("drm/todo: Add new debugfs todo") Cc: Greg Kroah-Hartman Cc: Daniel Vetter Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul Cc: Thomas Zimmermann Cc: Gerd Hoffmann Cc: Rob Herring Cc: Noralf Trønnes Cc: Eric Anholt Cc: Gerd Hoffmann Signed-off-by: Daniel Vetter Reviewed-by: Noralf Trønnes --- Documentation/gpu/todo.rst | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 25878dd048fd..66c123737c3d 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -212,9 +212,11 @@ struct drm_gem_object_funcs GEM objects can now have a function table instead of having the callbacks on the DRM driver struct. This is now the preferred way and drivers can be moved over. -Unfortunately some of the recently added GEM helpers are going in the wrong -direction by adding OPS macros that use the old, deprecated hooks. See -DRM_GEM_CMA_VMAP_DRIVER_OPS, DRM_GEM_SHMEM_DRIVER_OPS, and DRM_GEM_VRAM_DRIVER_PRIME. +DRM_GEM_CMA_VMAP_DRIVER_OPS, DRM_GEM_SHMEM_DRIVER_OPS already support this, but +DRM_GEM_VRAM_DRIVER_PRIME does not yet and needs to be aligend with the previous +two. We also need a 2nd version of the CMA define that doesn't require the +vmapping to be present (different hook for prime importing). Plus this needs to +be rolled out to all drivers using their own implementations, too. Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate ---------------------------------------------------------