diff mbox series

[PULL,09/14] block/commit: Drop bdrv_child_try_set_perm()

Message ID 20190618152318.24953-10-kwolf@redhat.com (mailing list archive)
State New, archived
Headers show
Series [PULL,01/14] iotests: Hide timestamps for skipped tests | expand

Commit Message

Kevin Wolf June 18, 2019, 3:23 p.m. UTC 
From: Max Reitz <mreitz@redhat.com>

commit_top_bs never requests or unshares any permissions.  There is no
reason to make this so explicit here.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/commit.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/block/commit.c b/block/commit.c
index c815def89a..212c6f639e 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -110,8 +110,6 @@  static void commit_abort(Job *job)
      * XXX Can (or should) we somehow keep 'consistent read' blocked even
      * after the failed/cancelled commit job is gone? If we already wrote
      * something to base, the intermediate images aren't valid any more. */
-    bdrv_child_try_set_perm(s->commit_top_bs->backing, 0, BLK_PERM_ALL,
-                            &error_abort);
     bdrv_replace_node(s->commit_top_bs, backing_bs(s->commit_top_bs),
                       &error_abort);