From patchwork Wed Jun 19 05:27:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 11003557 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2CE0514DB for ; Wed, 19 Jun 2019 07:10:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19A5026B39 for ; Wed, 19 Jun 2019 07:10:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0CFD928468; Wed, 19 Jun 2019 07:10:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 82A5E26B39 for ; Wed, 19 Jun 2019 07:10:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3ED846E2A6; Wed, 19 Jun 2019 07:10:25 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 073026E293 for ; Wed, 19 Jun 2019 05:27:36 +0000 (UTC) Received: by mail-pf1-x442.google.com with SMTP id d126so9025887pfd.2 for ; Tue, 18 Jun 2019 22:27:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TKj94I1UJ9U1wimP1ZXUVhx4jFR4v9J2rmetWcqu/jc=; b=F8DzgeDjGcvrXoAJA9z/orChqVp8Yw4Be6mGGUu+XjPRvgrBa+tSbEc0q1Xx7vLmij U9GhD23XXcHyUloN5/pd3kG7NqQPB1a58wwu6n4mtci7GsOIuAkN6CqJstuJXq/ICSen 9HUSJ5hRao1AnszqNUR0ExeB6Ffp9W/kLXzNJk/a57GTEJFwlUVTT3tfVxMJ5ADME37t IvXQKYsbflpkbVyHw7NbSzA2lXHDodHjut3Ziq+aZS7erKMil+dPtpcv2Zi0jKaMXXHm Oo/ljLzeZN0eFDJDrYIr35CyJSHxvzHNoL/9kg+q//VeQwePGUQPxv4YrWlfz5EUu2oA IVNg== X-Gm-Message-State: APjAAAVIFgFiipvLJqzZ3Bq3EJzIUTFTenwIwq7cI2WSTyOdRgP10Pds PPeuVwKHqAbkTCe80f31sDdeoJRi2r8= X-Google-Smtp-Source: APXvYqw9wK3jCk36OHTZfB+uFDa8ce3rAFNRgzwWwSVLXsIlElg+D1QR6c5WDjf+RkLuF6NhOb+KMQ== X-Received: by 2002:a63:2258:: with SMTP id t24mr6037843pgm.236.1560922055190; Tue, 18 Jun 2019 22:27:35 -0700 (PDT) Received: from localhost.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id l44sm534742pje.29.2019.06.18.22.27.33 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 18 Jun 2019 22:27:34 -0700 (PDT) From: Andrey Smirnov To: dri-devel@lists.freedesktop.org Subject: [PATCH v6 02/15] drm/bridge: tc358767: Simplify polling in tc_main_link_setup() Date: Tue, 18 Jun 2019 22:27:03 -0700 Message-Id: <20190619052716.16831-3-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190619052716.16831-1-andrew.smirnov@gmail.com> References: <20190619052716.16831-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 19 Jun 2019 07:10:14 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TKj94I1UJ9U1wimP1ZXUVhx4jFR4v9J2rmetWcqu/jc=; b=suY/vXMO4QTGQwZl4b4hihTIVEb82iVu4ggZaDzsG/eDO8iqQ3LZ31ZXNdlAMGSlge v6umLl8wBTpltFmkqIT1WwywnFeKp5GhIoTJce2RtjvJTRL95Le08tm3rkfHDvf8nT1M xvJS+YY9b0lsyLJm6SHyVVcz9oNdxpM1yx7aSh2hvimjopBmA4DW1Cntut8JMhHdAX6P PPL1zbdz1B9t/HY1Aww05BGUJVVqBwDSr+AOZVXSE2yOG8OvF3blcp7Tz6KGnm1rkFdZ FKomMg0EUUp3EKXOFlHaPO8MQ3jC6cN+P+bCTA0IspJykUhKm0yr1lqX77YtFDKPQFc+ 6HOw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cory Tusar , Andrey Smirnov , Andrey Gusakov , linux-kernel@vger.kernel.org, Tomi Valkeinen , Laurent Pinchart , Chris Healy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Replace explicit polling loop with equivalent call to tc_poll_timeout() for brevity. No functional change intended. Signed-off-by: Andrey Smirnov Reviewed-by: Andrzej Hajda Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Tomi Valkeinen Cc: Andrey Gusakov Cc: Philipp Zabel Cc: Cory Tusar Cc: Chris Healy Cc: Lucas Stach Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org --- drivers/gpu/drm/bridge/tc358767.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index fb8a1942ec54..f463ef6d4271 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -774,7 +774,6 @@ static int tc_main_link_enable(struct tc_data *tc) struct device *dev = tc->dev; unsigned int rate; u32 dp_phy_ctrl; - int timeout; u32 value; int ret; u8 tmp[8]; @@ -831,15 +830,10 @@ static int tc_main_link_enable(struct tc_data *tc) dp_phy_ctrl &= ~(DP_PHY_RST | PHY_M1_RST | PHY_M0_RST); tc_write(DP_PHY_CTRL, dp_phy_ctrl); - timeout = 1000; - do { - tc_read(DP_PHY_CTRL, &value); - udelay(1); - } while ((!(value & PHY_RDY)) && (--timeout)); - - if (timeout == 0) { + ret = tc_poll_timeout(tc, DP_PHY_CTRL, PHY_RDY, PHY_RDY, 1, 1000); + if (ret) { dev_err(dev, "timeout waiting for phy become ready"); - return -ETIMEDOUT; + return ret; } /* Set misc: 8 bits per color */