Btrfs: add missing inode version, ctime and mtime updates when punching hole
diff mbox series

Message ID 20190619120550.9825-1-fdmanana@kernel.org
State New
Headers show
Series
  • Btrfs: add missing inode version, ctime and mtime updates when punching hole
Related show

Commit Message

Filipe Manana June 19, 2019, 12:05 p.m. UTC
From: Filipe Manana <fdmanana@suse.com>

If the range for which we are punching a hole covers only part of a page,
we end up updating the inode item but we skip the update of the inode's
iversion, mtime and ctime. Fix that by ensuring we update those properties
of the inode.

A patch for fstests test case generic/059 that tests this as been sent
along with this fix.

Fixes: 2aaa66558172b0 ("Btrfs: add hole punching")
Fixes: e8c1c76e804b18 ("Btrfs: add missing inode update when punching hole")
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
 fs/btrfs/file.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

David Sterba June 20, 2019, 3:30 p.m. UTC | #1
On Wed, Jun 19, 2019 at 01:05:50PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> If the range for which we are punching a hole covers only part of a page,
> we end up updating the inode item but we skip the update of the inode's
> iversion, mtime and ctime. Fix that by ensuring we update those properties
> of the inode.
> 
> A patch for fstests test case generic/059 that tests this as been sent
> along with this fix.
> 
> Fixes: 2aaa66558172b0 ("Btrfs: add hole punching")
> Fixes: e8c1c76e804b18 ("Btrfs: add missing inode update when punching hole")
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Added to misc-next, thanks.

Patch
diff mbox series

diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index 89f5be2bfb43..1c7533db16b0 100644
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -2721,6 +2721,11 @@  static int btrfs_punch_hole(struct inode *inode, loff_t offset, loff_t len)
 		 * for detecting, at fsync time, if the inode isn't yet in the
 		 * log tree or it's there but not up to date.
 		 */
+		struct timespec64 now = current_time(inode);
+
+		inode_inc_iversion(inode);
+		inode->i_mtime = now;
+		inode->i_ctime = now;
 		trans = btrfs_start_transaction(root, 1);
 		if (IS_ERR(trans)) {
 			err = PTR_ERR(trans);