[v2] ALSA: hda/realtek: Add quirks for several Clevo notebook barebones
diff mbox series

Message ID 20190619113311.31656-1-rs@tuxedocomputers.com
State New
Headers show
Series
  • [v2] ALSA: hda/realtek: Add quirks for several Clevo notebook barebones
Related show

Commit Message

Richard Sailer June 19, 2019, 11:33 a.m. UTC
This adds 4 SND_PCI_QUIRK(...) lines for several barebone models of the ODM
Clevo. The model names are written in regex syntax to describe/match all clevo
models that are similar enough and use the same PCI SSID that this fixup works
for them.

Additionally the lines regarding SSID 0x96e1 and 0x97e1 didn't fix audio for the
all our Clevo notebooks using these SSIDs (models Clevo P960* and P970*) since
ALC1220_FIXP_CLEVO_PB51ED_PINS swapped pins that are not necesarry to be
swapped. This patch initiates ALC1220_FIXUP_CLEVO_P950 instead for these model
and fixes the audio.

This is strange since the System76 Oryx Pro also seems to be a P960 and
P970 barebone, so the original fixup should also not have worked for
them. @Jeremy: What's your take on this?

Signed-off-by: Richard Sailer <rs@tuxedocomputers.com>
---
 sound/pci/hda/patch_realtek.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Takashi Iwai June 27, 2019, 6:40 a.m. UTC | #1
On Wed, 19 Jun 2019 13:33:11 +0200,
Richard Sailer wrote:
> 
> This adds 4 SND_PCI_QUIRK(...) lines for several barebone models of the ODM
> Clevo. The model names are written in regex syntax to describe/match all clevo
> models that are similar enough and use the same PCI SSID that this fixup works
> for them.
> 
> Additionally the lines regarding SSID 0x96e1 and 0x97e1 didn't fix audio for the
> all our Clevo notebooks using these SSIDs (models Clevo P960* and P970*) since
> ALC1220_FIXP_CLEVO_PB51ED_PINS swapped pins that are not necesarry to be
> swapped. This patch initiates ALC1220_FIXUP_CLEVO_P950 instead for these model
> and fixes the audio.
> 
> This is strange since the System76 Oryx Pro also seems to be a P960 and
> P970 barebone, so the original fixup should also not have worked for
> them. @Jeremy: What's your take on this?
> 
> Signed-off-by: Richard Sailer <rs@tuxedocomputers.com>

FYI, I queued the patch now.  Let me know if you find anything new.


thanks,

Takashi
Richard Sailer June 27, 2019, 12:23 p.m. UTC | #2
On 27/06/2019 08:40, Takashi Iwai wrote:
> FYI, I queued the patch now.  
Nice, thanks for the info.

> Let me know if you find anything new.
Okay

> 
> 
> thanks,
> 
> Takashi

Patch
diff mbox series

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 1afb268f3da0..61dcd293afb1 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2461,9 +2461,10 @@  static const struct snd_pci_quirk alc882_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1558, 0x9501, "Clevo P950HR", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1558, 0x95e1, "Clevo P95xER", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1558, 0x95e2, "Clevo P950ER", ALC1220_FIXUP_CLEVO_P950),
-	SND_PCI_QUIRK(0x1558, 0x96e1, "System76 Oryx Pro (oryp5)", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
-	SND_PCI_QUIRK(0x1558, 0x97e1, "System76 Oryx Pro (oryp5)", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
-	SND_PCI_QUIRK(0x1558, 0x65d1, "Tuxedo Book XC1509", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
+	SND_PCI_QUIRK(0x1558, 0x96e1, "Clevo P960[ER][CDFN]-K", ALC1220_FIXUP_CLEVO_P950),
+	SND_PCI_QUIRK(0x1558, 0x97e1, "Clevo P970[ER][CDFN]", ALC1220_FIXUP_CLEVO_P950),
+	SND_PCI_QUIRK(0x1558, 0x65d1, "Clevo PB51[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
+	SND_PCI_QUIRK(0x1558, 0x67d1, "Clevo PB71[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
 	SND_PCI_QUIRK_VENDOR(0x1558, "Clevo laptop", ALC882_FIXUP_EAPD),
 	SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_FIXUP_EAPD),
 	SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo Y530", ALC882_FIXUP_LENOVO_Y530),