ARM: dts: imx6qdl-sr-som: fix AR8035 phy interface mode
diff mbox series

Message ID E1hdjBO-0007Yt-9M@rmk-PC.armlinux.org.uk
State New
Headers show
Series
  • ARM: dts: imx6qdl-sr-som: fix AR8035 phy interface mode
Related show

Commit Message

Russell King June 19, 2019, 10:35 p.m. UTC
A change to the AT803x driver fixed the handling of the phy interface
mode, but this breaks all platforms that use "rgmii" as the mode in
their DT.  Fix the Solidrun platforms.

Fixes: 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam June 19, 2019, 11:06 p.m. UTC | #1
Hi Russell,

On Wed, Jun 19, 2019 at 7:37 PM Russell King - ARM Linux admin
<linux@armlinux.org.uk> wrote:
>
> On Wed, Jun 19, 2019 at 11:35:58PM +0100, Russell King wrote:
> > A change to the AT803x driver fixed the handling of the phy interface
> > mode, but this breaks all platforms that use "rgmii" as the mode in
> > their DT.  Fix the Solidrun platforms.
> >
> > Fixes: 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Note that without this, SolidRun Hummingboard and Cubox-i platforms
> have no working ethernet with at least 5.1 kernels, which is a
> regression.

Commit 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode") fixes
this issue in mainline and it has already been applied to the 5.1
stable tree as well.

Thanks

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi
index 4ccb7afc4b35..6d7f6b9035bc 100644
--- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi
@@ -53,7 +53,7 @@ 
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_microsom_enet_ar8035>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-reset-duration = <2>;
 	phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>;
 	status = "okay";