t5551: use 'test_i18ngrep' to check translated output
diff mbox series

Message ID 20190624124446.32206-1-szeder.dev@gmail.com
State New
Headers show
  • t5551: use 'test_i18ngrep' to check translated output
Related show

Commit Message

SZEDER Gábor June 24, 2019, 12:44 p.m. UTC
The two tests 'invalid Content-Type rejected' and 'server-side error
detected' in 't5551-http-fetch-smart.sh' use "plain" 'grep' to check
that 'git clone' failed with the expected error message, but the
messages they are checking are translated, and, consequently, these
tests fail when the test script is run with GIT_TEST_GETTEXT_POISON

Use 'test_i18ngrep' instead.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>

The GETTEXT_POISON CI build jobs haven't caught these, because they
don't run the httpd (and svn, p4...) tests.  Should they?  Dunno.

 t/t5551-http-fetch-smart.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff mbox series

diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
index ac74626a7b..cb11f13d6d 100755
--- a/t/t5551-http-fetch-smart.sh
+++ b/t/t5551-http-fetch-smart.sh
@@ -199,7 +199,7 @@  test_expect_success 'GIT_SMART_HTTP can disable smart http' '
 test_expect_success 'invalid Content-Type rejected' '
 	test_must_fail git clone $HTTPD_URL/broken_smart/repo.git 2>actual &&
-	grep "not valid:" actual
+	test_i18ngrep "not valid:" actual
 test_expect_success 'create namespaced refs' '
@@ -466,7 +466,7 @@  test_expect_success 'GIT_TRACE_CURL_NO_DATA prevents data from being traced' '
 test_expect_success 'server-side error detected' '
 	test_must_fail git clone $HTTPD_URL/error_smart/repo.git 2>actual &&
-	grep "server-side error" actual
+	test_i18ngrep "server-side error" actual