ASoC: rt5677: depop stereo dac
diff mbox series

Message ID 20190624205239.150516-1-cujomalainey@chromium.org
State Accepted
Commit 24043d60ff50ac3b72644ddbdfb7fa2df93fd648
Headers show
Series
  • ASoC: rt5677: depop stereo dac
Related show

Commit Message

Curtis Malainey June 24, 2019, 8:52 p.m. UTC
Upon enabling the ASRC DAC we need a delay to avoid popping the
speakers.

Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
Cc: Ross Zwisler <zwisler@chromium.org>
---
 sound/soc/codecs/rt5677.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ross Zwisler June 24, 2019, 9:13 p.m. UTC | #1
On Mon, Jun 24, 2019 at 01:52:39PM -0700, Curtis Malainey wrote:
> Upon enabling the ASRC DAC we need a delay to avoid popping the
> speakers.
> 
> Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
> Cc: Ross Zwisler <zwisler@chromium.org>

This solves the popping issue for me.

Tested-by: Ross Zwisler <zwisler@google.com>

Patch
diff mbox series

diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 20b1d03530bd0..c779dc3474f9e 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -2608,7 +2608,8 @@  static const struct snd_soc_dapm_widget rt5677_dapm_widgets[] = {
 	SND_SOC_DAPM_SUPPLY_S("I2S2 ASRC", 1, RT5677_ASRC_1, 1, 0, NULL, 0),
 	SND_SOC_DAPM_SUPPLY_S("I2S3 ASRC", 1, RT5677_ASRC_1, 2, 0, NULL, 0),
 	SND_SOC_DAPM_SUPPLY_S("I2S4 ASRC", 1, RT5677_ASRC_1, 3, 0, NULL, 0),
-	SND_SOC_DAPM_SUPPLY_S("DAC STO ASRC", 1, RT5677_ASRC_2, 14, 0, NULL, 0),
+	SND_SOC_DAPM_SUPPLY_S("DAC STO ASRC", 1, RT5677_ASRC_2, 14, 0,
+		rt5677_filter_power_event, SND_SOC_DAPM_POST_PMU),
 	SND_SOC_DAPM_SUPPLY_S("DAC MONO2 L ASRC", 1, RT5677_ASRC_2, 13, 0, NULL,
 		0),
 	SND_SOC_DAPM_SUPPLY_S("DAC MONO2 R ASRC", 1, RT5677_ASRC_2, 12, 0, NULL,