| Message ID | 20190625040356.27473-5-tranmanphong@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | cleanup cppcheck signed shifting errors | expand |
On Tue, Jun 25, 2019 at 11:03:45AM +0700, Phong Tran wrote: > There is error from cppcheck tool > "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" > change to use BIT() marco for improvement. > > Signed-off-by: Phong Tran <tranmanphong@gmail.com> > --- > arch/arm/mach-exynos/suspend.c | 2 +- Thanks, applied with slightly different commit message. As Peter pointed, there is no error because of GCC. Usually we expect a reply to comments on LKML... and also you could take his hints and use them to improve the commit msg to properly describe what is the problem. Best regards, Krzysztof
diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c index be122af0de8f..983d5f1d0c29 100644 --- a/arch/arm/mach-exynos/suspend.c +++ b/arch/arm/mach-exynos/suspend.c @@ -285,7 +285,7 @@ static void exynos_pm_set_wakeup_mask(void) * Set wake-up mask registers * EXYNOS_EINT_WAKEUP_MASK is set by pinctrl driver in late suspend. */ - pmu_raw_writel(exynos_irqwake_intmask & ~(1 << 31), S5P_WAKEUP_MASK); + pmu_raw_writel(exynos_irqwake_intmask & ~BIT(31), S5P_WAKEUP_MASK); } static void exynos_pm_enter_sleep_mode(void)
There is error from cppcheck tool "Shifting signed 32-bit value by 31 bits is undefined behaviour errors" change to use BIT() marco for improvement. Signed-off-by: Phong Tran <tranmanphong@gmail.com> --- arch/arm/mach-exynos/suspend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)