ath10k: Move non-fatal warn logs to dbg level for SDIO chip
diff mbox series

Message ID 1561516175-13873-1-git-send-email-wgong@codeaurora.org
State New
Headers show
Series
  • ath10k: Move non-fatal warn logs to dbg level for SDIO chip
Related show

Commit Message

Wen Gong June 26, 2019, 2:29 a.m. UTC
ath10k will receive some message with invalid peer id from firmware.
reason is:
There are incoming frames to MAC hardware that NOT find relative
address search table, then peer id is invalid set by MAC hardware,
it is hardware's logic, so fix it in ath10k will be more convenient.

log:
ath10k_sdio mmc1:0001:1: Got RX ind from invalid peer: 65535

Tested with QCA6174 SDIO with firmware
WLAN.RMH.4.4.1-00007-QCARMSWP-1.

Signed-off-by: Wen Gong <wgong@codeaurora.org>
---
 drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo June 28, 2019, 7:12 p.m. UTC | #1
Wen Gong <wgong@codeaurora.org> wrote:

> ath10k will receive some message with invalid peer id from firmware.
> reason is:
> There are incoming frames to MAC hardware that NOT find relative
> address search table, then peer id is invalid set by MAC hardware,
> it is hardware's logic, so fix it in ath10k will be more convenient.
> 
> log:
> ath10k_sdio mmc1:0001:1: Got RX ind from invalid peer: 65535
> 
> Tested with QCA6174 SDIO with firmware
> WLAN.RMH.4.4.1-00007-QCARMSWP-1.
> 
> Signed-off-by: Wen Gong <wgong@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

bd1a4ac556df ath10k: Move non-fatal warn logs to dbg level for SDIO chip

Patch
diff mbox series

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index a20ea27..14b838f 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -2082,7 +2082,7 @@  static bool ath10k_htt_rx_proc_rx_ind_hl(struct ath10k_htt *htt,
 	spin_lock_bh(&ar->data_lock);
 	peer = ath10k_peer_find_by_id(ar, peer_id);
 	spin_unlock_bh(&ar->data_lock);
-	if (!peer)
+	if (!peer && peer_id != HTT_INVALID_PEERID)
 		ath10k_warn(ar, "Got RX ind from invalid peer: %u\n", peer_id);
 
 	num_mpdu_ranges = MS(__le32_to_cpu(rx->hdr.info1),