| Message ID | 20190704082736.25258-2-imammedo@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests: acpi: improve tests reproducability | expand |
On 7/4/19 10:27 AM, Igor Mammedov wrote: > IASL isn't needed when dumping ACPI tables from guest for > rebuild purposes. So move this part out from IASL branch. > > Makes rebuild-expected-aml.sh work without IASL installed > on host. > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > tests/bios-tables-test.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index d863233fe9..13bd166b81 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -597,12 +597,10 @@ static void test_acpi_one(const char *params, test_data *data) > test_acpi_rxsdt_table(data); > test_acpi_fadt_table(data); > > - if (iasl) { > - if (getenv(ACPI_REBUILD_EXPECTED_AML)) { > - dump_aml_files(data, true); > - } else { > - test_acpi_asl(data); > - } > + if (getenv(ACPI_REBUILD_EXPECTED_AML)) { > + dump_aml_files(data, true); > + } else if (iasl) { > + test_acpi_asl(data); > } > > /* >
Hi Igor, On 7/4/19 10:27 AM, Igor Mammedov wrote: > IASL isn't needed when dumping ACPI tables from guest for > rebuild purposes. So move this part out from IASL branch. > > Makes rebuild-expected-aml.sh work without IASL installed > on host. > > Signed-off-by: Igor Mammedov <imammedo@redhat.com> > --- > tests/bios-tables-test.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index d863233fe9..13bd166b81 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -597,12 +597,10 @@ static void test_acpi_one(const char *params, test_data *data) > test_acpi_rxsdt_table(data); > test_acpi_fadt_table(data); > > - if (iasl) { > - if (getenv(ACPI_REBUILD_EXPECTED_AML)) { > - dump_aml_files(data, true); > - } else { > - test_acpi_asl(data); > - } > + if (getenv(ACPI_REBUILD_EXPECTED_AML)) { > + dump_aml_files(data, true); > + } else if (iasl) { > + test_acpi_asl(data); > } > > /* > Reviewed-by: Eric Auger <eric.auger@redhat.com> Thanks Eric
diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index d863233fe9..13bd166b81 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -597,12 +597,10 @@ static void test_acpi_one(const char *params, test_data *data) test_acpi_rxsdt_table(data); test_acpi_fadt_table(data); - if (iasl) { - if (getenv(ACPI_REBUILD_EXPECTED_AML)) { - dump_aml_files(data, true); - } else { - test_acpi_asl(data); - } + if (getenv(ACPI_REBUILD_EXPECTED_AML)) { + dump_aml_files(data, true); + } else if (iasl) { + test_acpi_asl(data); } /*
IASL isn't needed when dumping ACPI tables from guest for rebuild purposes. So move this part out from IASL branch. Makes rebuild-expected-aml.sh work without IASL installed on host. Signed-off-by: Igor Mammedov <imammedo@redhat.com> --- tests/bios-tables-test.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)