[1/7] crypto: ux500: Use spinlock_t instead of struct spinlock
diff mbox series

Message ID 20190704153803.12739-2-bigeasy@linutronix.de
State Accepted
Delegated to: Herbert Xu
Headers show
Series
  • [1/7] crypto: ux500: Use spinlock_t instead of struct spinlock
Related show

Commit Message

Sebastian Andrzej Siewior July 4, 2019, 3:37 p.m. UTC
For spinlocks the type spinlock_t should be used instead of "struct
spinlock".

Use spinlock_t for spinlock's definition.

Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/crypto/ux500/cryp/cryp.h     | 4 ++--
 drivers/crypto/ux500/hash/hash_alg.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Thomas Gleixner July 26, 2019, 12:10 p.m. UTC | #1
On Thu, 4 Jul 2019, Sebastian Andrzej Siewior wrote:

Polite reminder...

> For spinlocks the type spinlock_t should be used instead of "struct
> spinlock".
> 
> Use spinlock_t for spinlock's definition.
> 
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  drivers/crypto/ux500/cryp/cryp.h     | 4 ++--
>  drivers/crypto/ux500/hash/hash_alg.h | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/ux500/cryp/cryp.h b/drivers/crypto/ux500/cryp/cryp.h
> index bd89504e81678..8da7f87b339b4 100644
> --- a/drivers/crypto/ux500/cryp/cryp.h
> +++ b/drivers/crypto/ux500/cryp/cryp.h
> @@ -241,12 +241,12 @@ struct cryp_device_data {
>  	struct clk *clk;
>  	struct regulator *pwr_regulator;
>  	int power_status;
> -	struct spinlock ctx_lock;
> +	spinlock_t ctx_lock;
>  	struct cryp_ctx *current_ctx;
>  	struct klist_node list_node;
>  	struct cryp_dma dma;
>  	bool power_state;
> -	struct spinlock power_state_spinlock;
> +	spinlock_t power_state_spinlock;
>  	bool restore_dev_ctx;
>  };
>  
> diff --git a/drivers/crypto/ux500/hash/hash_alg.h b/drivers/crypto/ux500/hash/hash_alg.h
> index ab2bd00c1c365..7c9bcc15125ff 100644
> --- a/drivers/crypto/ux500/hash/hash_alg.h
> +++ b/drivers/crypto/ux500/hash/hash_alg.h
> @@ -366,10 +366,10 @@ struct hash_device_data {
>  	phys_addr_t             phybase;
>  	struct klist_node	list_node;
>  	struct device		*dev;
> -	struct spinlock		ctx_lock;
> +	spinlock_t		ctx_lock;
>  	struct hash_ctx		*current_ctx;
>  	bool			power_state;
> -	struct spinlock		power_state_lock;
> +	spinlock_t		power_state_lock;
>  	struct regulator	*regulator;
>  	struct clk		*clk;
>  	bool			restore_dev_state;
> -- 
> 2.20.1
> 
>
Herbert Xu July 26, 2019, 12:32 p.m. UTC | #2
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> For spinlocks the type spinlock_t should be used instead of "struct
> spinlock".
> 
> Use spinlock_t for spinlock's definition.
> 
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> drivers/crypto/ux500/cryp/cryp.h     | 4 ++--
> drivers/crypto/ux500/hash/hash_alg.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)

Patch applied.  Thanks.

Patch
diff mbox series

diff --git a/drivers/crypto/ux500/cryp/cryp.h b/drivers/crypto/ux500/cryp/cryp.h
index bd89504e81678..8da7f87b339b4 100644
--- a/drivers/crypto/ux500/cryp/cryp.h
+++ b/drivers/crypto/ux500/cryp/cryp.h
@@ -241,12 +241,12 @@  struct cryp_device_data {
 	struct clk *clk;
 	struct regulator *pwr_regulator;
 	int power_status;
-	struct spinlock ctx_lock;
+	spinlock_t ctx_lock;
 	struct cryp_ctx *current_ctx;
 	struct klist_node list_node;
 	struct cryp_dma dma;
 	bool power_state;
-	struct spinlock power_state_spinlock;
+	spinlock_t power_state_spinlock;
 	bool restore_dev_ctx;
 };
 
diff --git a/drivers/crypto/ux500/hash/hash_alg.h b/drivers/crypto/ux500/hash/hash_alg.h
index ab2bd00c1c365..7c9bcc15125ff 100644
--- a/drivers/crypto/ux500/hash/hash_alg.h
+++ b/drivers/crypto/ux500/hash/hash_alg.h
@@ -366,10 +366,10 @@  struct hash_device_data {
 	phys_addr_t             phybase;
 	struct klist_node	list_node;
 	struct device		*dev;
-	struct spinlock		ctx_lock;
+	spinlock_t		ctx_lock;
 	struct hash_ctx		*current_ctx;
 	bool			power_state;
-	struct spinlock		power_state_lock;
+	spinlock_t		power_state_lock;
 	struct regulator	*regulator;
 	struct clk		*clk;
 	bool			restore_dev_state;