[GIT,PULL] Keys: Set 2 - request_key() improvements for 5.3
mbox series

Message ID 27327.1562361214@warthog.procyon.org.uk
State New
Headers show
Series
  • [GIT,PULL] Keys: Set 2 - request_key() improvements for 5.3
Related show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/keys-request-20190626

Message

David Howells July 5, 2019, 9:13 p.m. UTC
Hi Linus,

Here's my second block of keyrings changes for the next merge window.

These are all request_key()-related, including a fix and some improvements:

 (1) Fix the lack of a Link permission check on a key found by
     request_key(), thereby enabling request_key() to link keys that don't
     grant this permission to the target keyring (which must still grant
     Write permission).

     Note that the key must be in the caller's keyrings already to be
     found.

 (2) Invalidate used request_key authentication keys rather than revoking
     them, so that they get cleaned up immediately rather than hanging
     around till the expiry time is passed.

 (3) Move the RCU locks outwards from the keyring search functions so that
     a request_key_rcu() can be provided.  This can be called in RCU mode,
     so it can't sleep and can't upcall - but it can be called from
     LOOKUP_RCU pathwalk mode.

 (4) Cache the latest positive result of request_key*() temporarily in
     task_struct so that filesystems that make a lot of request_key() calls
     during pathwalk can take advantage of it to avoid having to redo the
     searching.  This requires CONFIG_KEYS_REQUEST_CACHE=y.

     It is assumed that the key just found is likely to be used multiple
     times in each step in an RCU pathwalk, and is likely to be reused for
     the next step too.

     Note that the cleanup of the cache is done on TIF_NOTIFY_RESUME, just
     before userspace resumes, and on exit.

David
---
The following changes since commit 45e0f30c30bb131663fbe1752974d6f2e39611e2:

  keys: Add capability-checking keyctl function (2019-06-19 13:27:45 +0100)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/keys-request-20190626

for you to fetch changes up to 3b8c4a08a471d56ecaaca939c972fdf5b8255629:

  keys: Kill off request_key_async{,_with_auxdata} (2019-06-26 20:58:13 +0100)

----------------------------------------------------------------
request_key improvements

----------------------------------------------------------------
David Howells (6):
      keys: Fix request_key() lack of Link perm check on found key
      keys: Invalidate used request_key authentication keys
      keys: Move the RCU locks outwards from the keyring search functions
      keys: Provide request_key_rcu()
      keys: Cache result of request_key*() temporarily in task_struct
      keys: Kill off request_key_async{,_with_auxdata}

 Documentation/security/keys/core.rst        |  38 ++------
 Documentation/security/keys/request-key.rst |  33 +++----
 include/keys/request_key_auth-type.h        |   1 +
 include/linux/key.h                         |  14 +--
 include/linux/sched.h                       |   5 +
 include/linux/tracehook.h                   |   7 ++
 kernel/cred.c                               |   9 ++
 security/keys/Kconfig                       |  18 ++++
 security/keys/internal.h                    |   6 +-
 security/keys/key.c                         |   4 +-
 security/keys/keyring.c                     |  16 ++--
 security/keys/proc.c                        |   4 +-
 security/keys/process_keys.c                |  41 ++++-----
 security/keys/request_key.c                 | 137 ++++++++++++++++++----------
 security/keys/request_key_auth.c            |  60 +++++++-----
 15 files changed, 229 insertions(+), 164 deletions(-)

Comments

pr-tracker-bot@kernel.org July 9, 2019, 3:15 a.m. UTC | #1
The pull request you sent on Fri, 05 Jul 2019 22:13:34 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/keys-request-20190626

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/f771fde82051976a6fc0fd570f8b86de4a92124b

Thank you!