xfs/449: test xfs_info on a mounted block device
diff mbox series

Message ID 20190706145217.13336-1-zlang@redhat.com
State New
Headers show
Series
  • xfs/449: test xfs_info on a mounted block device
Related show

Commit Message

Zorro Lang July 6, 2019, 2:52 p.m. UTC
There was a bug, xfs_info fails on a mounted block device:

  # xfs_info /dev/mapper/testdev
  xfs_info: /dev/mapper/testdev contains a mounted filesystem

  fatal error -- couldn't initialize XFS library

  xfsprogs has fixed it by:

    bbb43745 xfs_info: use findmnt to handle mounted block devices

Signed-off-by: Zorro Lang <zlang@redhat.com>
---
 tests/xfs/449 | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

Comments

Darrick J. Wong July 6, 2019, 3:35 p.m. UTC | #1
On Sat, Jul 06, 2019 at 10:52:17PM +0800, Zorro Lang wrote:
> There was a bug, xfs_info fails on a mounted block device:
> 
>   # xfs_info /dev/mapper/testdev
>   xfs_info: /dev/mapper/testdev contains a mounted filesystem
> 
>   fatal error -- couldn't initialize XFS library
> 
>   xfsprogs has fixed it by:
> 
>     bbb43745 xfs_info: use findmnt to handle mounted block devices
> 
> Signed-off-by: Zorro Lang <zlang@redhat.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  tests/xfs/449 | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/xfs/449 b/tests/xfs/449
> index 6a031685..7aae1545 100755
> --- a/tests/xfs/449
> +++ b/tests/xfs/449
> @@ -60,10 +60,15 @@ echo GROWFS >> $seqres.full
>  cat $tmp.growfs >> $seqres.full
>  diff -u $tmp.mkfs $tmp.growfs
>  
> -$XFS_INFO_PROG $SCRATCH_MNT > $tmp.info
> -echo INFO >> $seqres.full
> -cat $tmp.info >> $seqres.full
> -diff -u $tmp.mkfs $tmp.info
> +$XFS_INFO_PROG $SCRATCH_MNT > $tmp.info.mnt
> +echo INFO_MNT >> $seqres.full
> +cat $tmp.info.mnt >> $seqres.full
> +diff -u $tmp.mkfs $tmp.info.mnt
> +
> +$XFS_INFO_PROG $SCRATCH_DEV > $tmp.info.dev
> +echo INFO_DEV >> $seqres.full
> +cat $tmp.info.dev >> $seqres.full
> +diff -u $tmp.mkfs $tmp.info.dev
>  
>  echo "Silence is golden."
>  status=0
> -- 
> 2.17.2
>

Patch
diff mbox series

diff --git a/tests/xfs/449 b/tests/xfs/449
index 6a031685..7aae1545 100755
--- a/tests/xfs/449
+++ b/tests/xfs/449
@@ -60,10 +60,15 @@  echo GROWFS >> $seqres.full
 cat $tmp.growfs >> $seqres.full
 diff -u $tmp.mkfs $tmp.growfs
 
-$XFS_INFO_PROG $SCRATCH_MNT > $tmp.info
-echo INFO >> $seqres.full
-cat $tmp.info >> $seqres.full
-diff -u $tmp.mkfs $tmp.info
+$XFS_INFO_PROG $SCRATCH_MNT > $tmp.info.mnt
+echo INFO_MNT >> $seqres.full
+cat $tmp.info.mnt >> $seqres.full
+diff -u $tmp.mkfs $tmp.info.mnt
+
+$XFS_INFO_PROG $SCRATCH_DEV > $tmp.info.dev
+echo INFO_DEV >> $seqres.full
+cat $tmp.info.dev >> $seqres.full
+diff -u $tmp.mkfs $tmp.info.dev
 
 echo "Silence is golden."
 status=0