| Message ID | 20190707223303.6755-16-digetx@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | More improvements for Tegra30 devfreq driver | expand |
On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > There is another kHz-conversion bug in the code, resulting in integer > overflow. Although, this time the resulting value is 4294966296 and it's > close to ULONG_MAX, which is okay in this case. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/devfreq/tegra30-devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index 0de1efdaabf4..60ebf9c9cd86 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -172,7 +172,7 @@ struct tegra_actmon_emc_ratio { > }; > > static const struct tegra_actmon_emc_ratio actmon_emc_ratios[] = { > - { 1400000, ULONG_MAX }, > + { 1400000, ULONG_MAX / KHZ }, > { 1200000, 750000 }, > { 1100000, 600000 }, > { 1000000, 500000 }, > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index 0de1efdaabf4..60ebf9c9cd86 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -172,7 +172,7 @@ struct tegra_actmon_emc_ratio { }; static const struct tegra_actmon_emc_ratio actmon_emc_ratios[] = { - { 1400000, ULONG_MAX }, + { 1400000, ULONG_MAX / KHZ }, { 1200000, 750000 }, { 1100000, 600000 }, { 1000000, 500000 },
There is another kHz-conversion bug in the code, resulting in integer overflow. Although, this time the resulting value is 4294966296 and it's close to ULONG_MAX, which is okay in this case. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/devfreq/tegra30-devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)