[v10,06/12] NFS: for "inter" copy treat ESTALE as ENOTSUPP
diff mbox series

Message ID 20190708192444.12664-7-olga.kornievskaia@gmail.com
State New
Headers show
  • client-side support for "inter" SSC copy
Related show

Commit Message

Olga Kornievskaia July 8, 2019, 7:24 p.m. UTC
From: Olga Kornievskaia <kolga@netapp.com>

If the client sends an "inter" copy to the destination server but
it only supports "intra" copy, it can return ESTALE (since it
doesn't know anything about the file handle from the other server
and does not recognize the special case of "inter" copy). Translate
this error as ENOTSUPP and also send OFFLOAD_CANCEL to the source
server so that it can clean up state.

Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
 fs/nfs/nfs42proc.c | 5 +++++
 1 file changed, 5 insertions(+)

diff mbox series

diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c
index e34ade844737..6ed5a16dc511 100644
--- a/fs/nfs/nfs42proc.c
+++ b/fs/nfs/nfs42proc.c
@@ -391,6 +391,11 @@  ssize_t nfs42_proc_copy(struct file *src, loff_t pos_src,
 			args.sync = true;
 			dst_exception.retry = 1;
+		} else if (err == -ESTALE &&
+				!nfs42_files_from_same_server(src, dst)) {
+			nfs42_do_offload_cancel_async(src, &args.src_stateid);
+			err = -EOPNOTSUPP;
+			break;
 		err2 = nfs4_handle_exception(server, err, &src_exception);