[Bug,204119] scsi_mod: Could not allocate 4104 bytes percpu data
diff mbox series

Message ID bug-204119-11613-Vk6aHkxTQA@https.bugzilla.kernel.org/
State Deferred
Headers show
Series
  • [Bug,204119] scsi_mod: Could not allocate 4104 bytes percpu data
Related show

Commit Message

bugzilla-daemon@bugzilla.kernel.org July 10, 2019, 3:09 a.m. UTC
https://bugzilla.kernel.org/show_bug.cgi?id=204119

--- Comment #6 from Bart Van Assche (bvanassche@acm.org) ---
The "size=4104" in the error message probably refers to the SCSI log buffer.
From drivers/scsi/scsi_logging.c:

#define SCSI_LOG_SPOOLSIZE 4096
struct scsi_log_buf {
        char buffer[SCSI_LOG_SPOOLSIZE];
        unsigned long map;
};
static DEFINE_PER_CPU(struct scsi_log_buf, scsi_format_log);

I am not aware of any changes between kernel versions v5.1 and v5.2 in the SCSI
logging mechanism so I don't think that this indicates a regression in the SCSI
subsystem. Anyway, does this patch help?

Patch
diff mbox series

diff --git a/drivers/scsi/scsi_logging.c b/drivers/scsi/scsi_logging.c
index 39b8cc4574b4..148d8635d5f6 100644
--- a/drivers/scsi/scsi_logging.c
+++ b/drivers/scsi/scsi_logging.c
@@ -15,7 +15,7 @@ 
 #include <scsi/scsi_eh.h>
 #include <scsi/scsi_dbg.h>

-#define SCSI_LOG_SPOOLSIZE 4096
+#define SCSI_LOG_SPOOLSIZE SCSI_LOG_BUFSIZE

 #if (SCSI_LOG_SPOOLSIZE / SCSI_LOG_BUFSIZE) > BITS_PER_LONG
 #warning SCSI logging bitmask too large