common/rc: print out kernel version too
diff mbox series

Message ID 20190710175809.13391-1-mfo@canonical.com
State New
Headers show
Series
  • common/rc: print out kernel version too
Related show

Commit Message

Mauricio Faria de Oliveira July 10, 2019, 5:58 p.m. UTC
The kernel version (uname -v) may also be needed in addition to
the kernel release (uname -r) in order to properly identify and
distinguish different kernel builds in some cases/distributions.

For example, in the Ubuntu kernel package the test/debug string
is usually a suffix to the version field, not the release field.

  $ uname -rv
  4.15.0-51-generic #55-Ubuntu SMP Wed May 15 14:27:21 UTC 2019

  $ uname -rv
  4.15.0-51-generic #55+test20190520b1 SMP Mon May 20 11:57:40 -03 2019

Looking at other OSes uname(1) man pages it looks like '-v' is
quite standard, and the Linux man page only cites '-p' and '-i'
as non-portable, so the change should be OK. The only caller is
the 'check' script for the header print out, so it's contained.

Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gabriel Krisman Bertazi July 10, 2019, 7:03 p.m. UTC | #1
Mauricio Faria de Oliveira <mfo@canonical.com> writes:

> The kernel version (uname -v) may also be needed in addition to
> the kernel release (uname -r) in order to properly identify and
> distinguish different kernel builds in some cases/distributions.
>
> For example, in the Ubuntu kernel package the test/debug string
> is usually a suffix to the version field, not the release field.
>
>   $ uname -rv
>   4.15.0-51-generic #55-Ubuntu SMP Wed May 15 14:27:21 UTC 2019
>
>   $ uname -rv
>   4.15.0-51-generic #55+test20190520b1 SMP Mon May 20 11:57:40 -03 2019
>
> Looking at other OSes uname(1) man pages it looks like '-v' is
> quite standard, and the Linux man page only cites '-p' and '-i'
> as non-portable, so the change should be OK. The only caller is
> the 'check' script for the header print out, so it's contained.
>

I'm just considering that -v also prints more clutter like the kernel
build date.  Do you need it? It seems off for the PLATFORM line,
which has stuff not kernel related.  Can you trim the output a
bit to remove it?

Anyway,

Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Mauricio Faria de Oliveira July 10, 2019, 7:16 p.m. UTC | #2
,

On Wed, Jul 10, 2019 at 4:04 PM Gabriel Krisman Bertazi
<krisman@collabora.com> wrote:
>
> Mauricio Faria de Oliveira <mfo@canonical.com> writes:
>
> > The kernel version (uname -v) may also be needed in addition to
> > the kernel release (uname -r) in order to properly identify and
> > distinguish different kernel builds in some cases/distributions.
> >
> > For example, in the Ubuntu kernel package the test/debug string
> > is usually a suffix to the version field, not the release field.
> >
> >   $ uname -rv
> >   4.15.0-51-generic #55-Ubuntu SMP Wed May 15 14:27:21 UTC 2019
> >
> >   $ uname -rv
> >   4.15.0-51-generic #55+test20190520b1 SMP Mon May 20 11:57:40 -03 2019
> >
> > Looking at other OSes uname(1) man pages it looks like '-v' is
> > quite standard, and the Linux man page only cites '-p' and '-i'
> > as non-portable, so the change should be OK. The only caller is
> > the 'check' script for the header print out, so it's contained.
> >
>
> I'm just considering that -v also prints more clutter like the kernel
> build date.  Do you need it? It seems off for the PLATFORM line,
> which has stuff not kernel related.  Can you trim the output a
> bit to remove it?
>

It indeed prints out some clutter that's usually not required,
but it's hard to tell which parts of it may (not) be useful in general
for particular/different users, to consider trimming it,
so the complete string seemed to be the way go IMO.

> Anyway,
>
> Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>

Thanks for reviewing.

>
> --
> Gabriel Krisman Bertazi

cheers,


--
Mauricio Faria de Oliveira

Patch
diff mbox series

diff --git a/common/rc b/common/rc
index dcd591b33b87..000a7cc821cf 100644
--- a/common/rc
+++ b/common/rc
@@ -2794,7 +2794,7 @@  _full_platform_details()
 {
      local os=`uname -s`
      local host=`hostname -s`
-     local kernel=`uname -r`
+     local kernel=`uname -rv`
      local platform=`uname -m`
      echo "$os/$platform $host $kernel"
 }