ASoC: rt5677: remove superfluous set
diff mbox series

Message ID 20190711002838.35363-1-cujomalainey@chromium.org
State Accepted
Commit 4dc057a786dc23fd1ed70e6bcab691c0f26daa1e
Headers show
Series
  • ASoC: rt5677: remove superfluous set
Related show

Commit Message

Curtis Malainey July 11, 2019, 12:28 a.m. UTC
We define this variable with the same value, no need to set it twice

Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
---
 sound/soc/codecs/rt5677.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Curtis Malainey July 22, 2019, 1:16 p.m. UTC | #1
Hi Mark,

Can you please remove this patch? I made an error in my testing and
the patch should not be applied.

Curtis

On Mon, Jul 22, 2019 at 6:22 AM Mark Brown <broonie@kernel.org> wrote:
>
> The patch
>
>    ASoC: rt5677: remove superfluous set
>
> has been applied to the asoc tree at
>
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
>
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
>
> From 4dc057a786dc23fd1ed70e6bcab691c0f26daa1e Mon Sep 17 00:00:00 2001
> From: Curtis Malainey <cujomalainey@chromium.org>
> Date: Wed, 10 Jul 2019 17:28:38 -0700
> Subject: [PATCH] ASoC: rt5677: remove superfluous set
>
> We define this variable with the same value, no need to set it twice
>
> Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
> Link: https://lore.kernel.org/r/20190711002838.35363-1-cujomalainey@chromium.org
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  sound/soc/codecs/rt5677.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
> index c779dc3474f9..deaed5132dc9 100644
> --- a/sound/soc/codecs/rt5677.c
> +++ b/sound/soc/codecs/rt5677.c
> @@ -5098,7 +5098,6 @@ static irqreturn_t rt5677_irq(int unused, void *data)
>                         goto exit;
>                 }
>
> -               irq_fired = false;
>                 for (i = 0; i < RT5677_IRQ_NUM; i++) {
>                         if (reg_irq & rt5677_irq_descs[i].status_mask) {
>                                 irq_fired = true;
> --
> 2.20.1
>
Mark Brown July 22, 2019, 3:22 p.m. UTC | #2
On Mon, Jul 22, 2019 at 07:16:28AM -0600, Curtis Malainey wrote:

> Can you please remove this patch? I made an error in my testing and
> the patch should not be applied.

As covered in the mail you're replying to:

> > If any updates are required or you are submitting further changes they
> > should be sent as incremental updates against current git, existing
> > patches will not be replaced.

So send a revert explaining what the problem is.

Patch
diff mbox series

diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index c779dc3474f9e..deaed5132dc95 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -5098,7 +5098,6 @@  static irqreturn_t rt5677_irq(int unused, void *data)
 			goto exit;
 		}
 
-		irq_fired = false;
 		for (i = 0; i < RT5677_IRQ_NUM; i++) {
 			if (reg_irq & rt5677_irq_descs[i].status_mask) {
 				irq_fired = true;