| Message ID | 20190711174906.GA10867@hari-Inspiron-1545 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | sound: soc: codecs: wcd9335: fix "conversion to bool not needed here" | expand |
On Thu, 2019-07-11 at 23:19 +0530, Hariprasad Kelam wrote: > Fix below issue reported by coccicheck > sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not > needed here > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > --- > sound/soc/codecs/wcd9335.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c > index 1bbbe42..85a8d10 100644 > --- a/sound/soc/codecs/wcd9335.c > +++ b/sound/soc/codecs/wcd9335.c > @@ -3988,12 +3988,7 @@ static irqreturn_t wcd9335_slimbus_irq(int irq, void *data) > regmap_read(wcd->if_regmap, > WCD9335_SLIM_PGD_PORT_INT_RX_SOURCE0 + j, &val); > if (val) { > - if (!tx) > - reg = WCD9335_SLIM_PGD_PORT_INT_EN0 + > - (port_id / 8); > - else > - reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + > - (port_id / 8); > + reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + (port_id / 8); > regmap_read( > wcd->if_regmap, reg, &int_val); > /* This change makes no sense and doesn't match the commit message.
On Thu, Jul 11, 2019 at 03:00:00PM -0700, Joe Perches wrote: > On Thu, 2019-07-11 at 23:19 +0530, Hariprasad Kelam wrote: > > Fix below issue reported by coccicheck > > sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not > > needed here > > > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > > --- > > sound/soc/codecs/wcd9335.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c > > index 1bbbe42..85a8d10 100644 > > --- a/sound/soc/codecs/wcd9335.c > > +++ b/sound/soc/codecs/wcd9335.c > > @@ -3988,12 +3988,7 @@ static irqreturn_t wcd9335_slimbus_irq(int irq, void *data) > > regmap_read(wcd->if_regmap, > > WCD9335_SLIM_PGD_PORT_INT_RX_SOURCE0 + j, &val); > > if (val) { > > - if (!tx) > > - reg = WCD9335_SLIM_PGD_PORT_INT_EN0 + > > - (port_id / 8); > > - else > > - reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + > > - (port_id / 8); > > + reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + (port_id / 8); > > regmap_read( > > wcd->if_regmap, reg, &int_val); > > /* > > This change makes no sense and doesn't match the commit message. > > Please ignore this patch. > Both statments in if/else loop looked > similar to me but they are different.
On Thu, Jul 11, 2019 at 03:00:00PM -0700, Joe Perches wrote: > On Thu, 2019-07-11 at 23:19 +0530, Hariprasad Kelam wrote: > > Fix below issue reported by coccicheck > > sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not > > needed here > > > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > > --- > > sound/soc/codecs/wcd9335.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c > > index 1bbbe42..85a8d10 100644 > > --- a/sound/soc/codecs/wcd9335.c > > +++ b/sound/soc/codecs/wcd9335.c > > @@ -3988,12 +3988,7 @@ static irqreturn_t wcd9335_slimbus_irq(int irq, void *data) > > regmap_read(wcd->if_regmap, > > WCD9335_SLIM_PGD_PORT_INT_RX_SOURCE0 + j, &val); > > if (val) { > > - if (!tx) > > - reg = WCD9335_SLIM_PGD_PORT_INT_EN0 + > > - (port_id / 8); > > - else > > - reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + > > - (port_id / 8); > > + reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + (port_id / 8); > > regmap_read( > > wcd->if_regmap, reg, &int_val); > > /* > > This change makes no sense and doesn't match the commit message. > >Please ignore this patch. Both the statments in if/else look similar to >me but they are not.
diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 1bbbe42..85a8d10 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -3988,12 +3988,7 @@ static irqreturn_t wcd9335_slimbus_irq(int irq, void *data) regmap_read(wcd->if_regmap, WCD9335_SLIM_PGD_PORT_INT_RX_SOURCE0 + j, &val); if (val) { - if (!tx) - reg = WCD9335_SLIM_PGD_PORT_INT_EN0 + - (port_id / 8); - else - reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + - (port_id / 8); + reg = WCD9335_SLIM_PGD_PORT_INT_TX_EN0 + (port_id / 8); regmap_read( wcd->if_regmap, reg, &int_val); /*
Fix below issue reported by coccicheck sound/soc/codecs/wcd9335.c:3991:25-30: WARNING: conversion to bool not needed here Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> --- sound/soc/codecs/wcd9335.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)