| Message ID | 20190711171726.GA4356@hari-Inspiron-1545 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | sound: pci: emu10k1: Remove unneeded variable "change" | expand |
On 7/11/2019 7:17 PM, Hariprasad Kelam wrote: > fix below issue reported by coccicheck > sound/pci/emu10k1/emu10k1x.c:1077:5-11: Unneeded variable: "change". > Return "0" on line 1092 > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> Since the function always return 0 and you perform code clean-up then maybe it would be a good idea to just change function to void instead of returning int value which does not seem to have use. Michal W. > --- > sound/pci/emu10k1/emu10k1x.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/pci/emu10k1/emu10k1x.c b/sound/pci/emu10k1/emu10k1x.c > index 67d6473..9cf8183 100644 > --- a/sound/pci/emu10k1/emu10k1x.c > +++ b/sound/pci/emu10k1/emu10k1x.c > @@ -1074,7 +1074,6 @@ static int snd_emu10k1x_shared_spdif_put(struct snd_kcontrol *kcontrol, > { > struct emu10k1x *emu = snd_kcontrol_chip(kcontrol); > unsigned int val; > - int change = 0; > > val = ucontrol->value.integer.value[0] ; > > @@ -1089,7 +1088,7 @@ static int snd_emu10k1x_shared_spdif_put(struct snd_kcontrol *kcontrol, > snd_emu10k1x_ptr_write(emu, ROUTING, 0, 0x1003F); > snd_emu10k1x_gpio_write(emu, 0x1080); > } > - return change; > + return 0; > } > > static const struct snd_kcontrol_new snd_emu10k1x_shared_spdif =
On Fri, 12 Jul 2019 10:06:23 +0200, Wasko, Michal wrote: > > > On 7/11/2019 7:17 PM, Hariprasad Kelam wrote: > > fix below issue reported by coccicheck > sound/pci/emu10k1/emu10k1x.c:1077:5-11: Unneeded variable: "change". > Return "0" on line 1092 > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > > Since the function always return 0 and you perform code clean-up then > maybe it would be a good idea to just change function to void instead > of returning int value which does not seem to have use. No, it's a callback function. Takashi
On Thu, 11 Jul 2019 19:17:26 +0200, Hariprasad Kelam wrote: > > fix below issue reported by coccicheck > sound/pci/emu10k1/emu10k1x.c:1077:5-11: Unneeded variable: "change". > Return "0" on line 1092 > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> Applied, thanks. Takashi
diff --git a/sound/pci/emu10k1/emu10k1x.c b/sound/pci/emu10k1/emu10k1x.c index 67d6473..9cf8183 100644 --- a/sound/pci/emu10k1/emu10k1x.c +++ b/sound/pci/emu10k1/emu10k1x.c @@ -1074,7 +1074,6 @@ static int snd_emu10k1x_shared_spdif_put(struct snd_kcontrol *kcontrol, { struct emu10k1x *emu = snd_kcontrol_chip(kcontrol); unsigned int val; - int change = 0; val = ucontrol->value.integer.value[0] ; @@ -1089,7 +1088,7 @@ static int snd_emu10k1x_shared_spdif_put(struct snd_kcontrol *kcontrol, snd_emu10k1x_ptr_write(emu, ROUTING, 0, 0x1003F); snd_emu10k1x_gpio_write(emu, 0x1080); } - return change; + return 0; } static const struct snd_kcontrol_new snd_emu10k1x_shared_spdif =
fix below issue reported by coccicheck sound/pci/emu10k1/emu10k1x.c:1077:5-11: Unneeded variable: "change". Return "0" on line 1092 Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> --- sound/pci/emu10k1/emu10k1x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)