| Message ID | 20190715032017.7311-1-huangfq.daxian@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On 2019/07/15, Fuqian Huang wrote: > In commit 518a2f1925c3 > ("dma-mapping: zero memory returned from dma_alloc_*"), > dma_alloc_coherent has already zeroed the memory. > So memset is not needed. > > Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com> > --- > Changes in v3: > - Use actual commit rather than the merge commit in the commit message > > drivers/video/fbdev/mmp/fb/mmpfb.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Emil Velikov <emil.velikov@collabora.com> -Emil
On 7/15/19 12:40 PM, Emil Velikov wrote: > On 2019/07/15, Fuqian Huang wrote: >> In commit 518a2f1925c3 >> ("dma-mapping: zero memory returned from dma_alloc_*"), >> dma_alloc_coherent has already zeroed the memory. >> So memset is not needed. >> >> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com> >> --- >> Changes in v3: >> - Use actual commit rather than the merge commit in the commit message >> >> drivers/video/fbdev/mmp/fb/mmpfb.c | 1 - >> 1 file changed, 1 deletion(-) >> > > Reviewed-by: Emil Velikov <emil.velikov@collabora.com> Patch queued for v5.4, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
diff --git a/drivers/video/fbdev/mmp/fb/mmpfb.c b/drivers/video/fbdev/mmp/fb/mmpfb.c index e5b56f2199df..47bc7c59bbd8 100644 --- a/drivers/video/fbdev/mmp/fb/mmpfb.c +++ b/drivers/video/fbdev/mmp/fb/mmpfb.c @@ -612,7 +612,6 @@ static int mmpfb_probe(struct platform_device *pdev) ret = -ENOMEM; goto failed_destroy_mutex; } - memset(fbi->fb_start, 0, fbi->fb_size); dev_info(fbi->dev, "fb %dk allocated\n", fbi->fb_size/1024); /* fb power on */
In commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*"), dma_alloc_coherent has already zeroed the memory. So memset is not needed. Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com> --- Changes in v3: - Use actual commit rather than the merge commit in the commit message drivers/video/fbdev/mmp/fb/mmpfb.c | 1 - 1 file changed, 1 deletion(-)