| Message ID | 20190715202101.16060-1-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | f90b8fda3a9d72a9422ea80ae95843697f94ea4a |
| Headers | show |
| Series | ARM: dts: gemini: Set DIR-685 SPI CS as active low | expand |
Hi,
[This is an automated email]
This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all
The bot has tested the following trees: v5.2.1, v5.1.18, v4.19.59, v4.14.133, v4.9.185, v4.4.185.
v5.2.1: Build OK!
v5.1.18: Build OK!
v4.19.59: Failed to apply! Possible dependencies:
Unable to calculate
v4.14.133: Failed to apply! Possible dependencies:
ea6f23f59331 ("ARM: dts: Add TVE/TVC and ILI9322 panel to DIR-685")
v4.9.185: Failed to apply! Possible dependencies:
22789ae3bbb1 ("ARM: dts: Add DTS file for D-Link DIR-685")
9be0d7f87eff ("ARM: dts: add device tree for Gemini SoC and SQ201")
ea6f23f59331 ("ARM: dts: Add TVE/TVC and ILI9322 panel to DIR-685")
fe7bf9dcfff5 ("ARM: dts: add a devicetree for Raidsonic NAS IB-4220-B")
v4.4.185: Failed to apply! Possible dependencies:
22789ae3bbb1 ("ARM: dts: Add DTS file for D-Link DIR-685")
9be0d7f87eff ("ARM: dts: add device tree for Gemini SoC and SQ201")
ea6f23f59331 ("ARM: dts: Add TVE/TVC and ILI9322 panel to DIR-685")
fe7bf9dcfff5 ("ARM: dts: add a devicetree for Raidsonic NAS IB-4220-B")
NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
--
Thanks,
Sasha
diff --git a/arch/arm/boot/dts/gemini-dlink-dir-685.dts b/arch/arm/boot/dts/gemini-dlink-dir-685.dts index 3613f05f8a80..bfaa2de63a10 100644 --- a/arch/arm/boot/dts/gemini-dlink-dir-685.dts +++ b/arch/arm/boot/dts/gemini-dlink-dir-685.dts @@ -64,7 +64,7 @@ gpio-sck = <&gpio1 5 GPIO_ACTIVE_HIGH>; gpio-miso = <&gpio1 8 GPIO_ACTIVE_HIGH>; gpio-mosi = <&gpio1 7 GPIO_ACTIVE_HIGH>; - cs-gpios = <&gpio0 20 GPIO_ACTIVE_HIGH>; + cs-gpios = <&gpio0 20 GPIO_ACTIVE_LOW>; num-chipselects = <1>; panel: display@0 {
The SPI to the display on the DIR-685 is active low, we were just saved by the SPI library enforcing active low on everything before, so set it as active low to avoid ambiguity. Cc: stable@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- ARM SoC folks: please apply this directly to fixes. --- arch/arm/boot/dts/gemini-dlink-dir-685.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)