[v1] ACPI / APEI: Get rid of NULL_UUID_LE constant
diff mbox series

Message ID 20190717105543.76244-1-andriy.shevchenko@linux.intel.com
State Mainlined, archived
Headers show
Series
  • [v1] ACPI / APEI: Get rid of NULL_UUID_LE constant
Related show

Commit Message

Andy Shevchenko July 17, 2019, 10:55 a.m. UTC
This is a missed part of the commit 5b53696a30d5
("ACPI / APEI: Switch to use new generic UUID API"), i.e.
replacing old definition with a global constant variable.

Cc: Borislav Petkov <bp@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/acpi/apei/ghes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Morse July 25, 2019, 12:44 p.m. UTC | #1
Hi,

On 17/07/2019 11:55, Andy Shevchenko wrote:
> This is a missed part of the commit 5b53696a30d5
> ("ACPI / APEI: Switch to use new generic UUID API"), i.e.
> replacing old definition with a global constant variable.

Reviewed-by: James Morse <james.morse@arm.com>

Thanks,

James
Rafael J. Wysocki Aug. 26, 2019, 9:04 a.m. UTC | #2
On Wednesday, July 17, 2019 12:55:43 PM CEST Andy Shevchenko wrote:
> This is a missed part of the commit 5b53696a30d5
> ("ACPI / APEI: Switch to use new generic UUID API"), i.e.
> replacing old definition with a global constant variable.
> 
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/acpi/apei/ghes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index a66e00fe31fe..451269a2f47c 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -483,7 +483,7 @@ static void ghes_do_proc(struct ghes *ghes,
>  	int sev, sec_sev;
>  	struct acpi_hest_generic_data *gdata;
>  	guid_t *sec_type;
> -	guid_t *fru_id = &NULL_UUID_LE;
> +	const guid_t *fru_id = &guid_null;
>  	char *fru_text = "";
>  
>  	sev = ghes_severity(estatus->error_severity);
> 

Applied, thanks!

Patch
diff mbox series

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index a66e00fe31fe..451269a2f47c 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -483,7 +483,7 @@  static void ghes_do_proc(struct ghes *ghes,
 	int sev, sec_sev;
 	struct acpi_hest_generic_data *gdata;
 	guid_t *sec_type;
-	guid_t *fru_id = &NULL_UUID_LE;
+	const guid_t *fru_id = &guid_null;
 	char *fru_text = "";
 
 	sev = ghes_severity(estatus->error_severity);