drm/i915/guc: Allocate non-swappable memory for internal objects
diff mbox series

Message ID 20190718092942.23179-1-chris@chris-wilson.co.uk
State New
Headers show
Series
  • drm/i915/guc: Allocate non-swappable memory for internal objects
Related show

Commit Message

Chris Wilson July 18, 2019, 9:29 a.m. UTC
All internal GuC objects are perma-pinned into the GGTT and thus
not-swapped. We do not need to allocate a shmemfs inode for these,
merely a collection of pages to be kept in memory.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Wilson July 18, 2019, 10:17 a.m. UTC | #1
Quoting Patchwork (2019-07-18 11:14:04)
> == Series Details ==
> 
> Series: drm/i915/guc: Allocate non-swappable memory for internal objects
> URL   : https://patchwork.freedesktop.org/series/63872/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6503 -> Patchwork_13684
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_13684 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_13684, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13684/
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_13684:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_module_load@reload:
>     - fi-apl-guc:         [PASS][1] -> [DMESG-FAIL][2] +21 similar issues
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6503/fi-apl-guc/igt@i915_module_load@reload.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13684/fi-apl-guc/igt@i915_module_load@reload.html

A few places relying on the implicit clear.
-Chris
Daniele Ceraolo Spurio July 18, 2019, 3:35 p.m. UTC | #2
On 7/18/19 2:29 AM, Chris Wilson wrote:
> All internal GuC objects are perma-pinned into the GGTT and thus
> not-swapped. We do not need to allocate a shmemfs inode for these,
> merely a collection of pages to be kept in memory.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>

Makes sense.

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> index 83f2c197375f..d66f8f9c5654 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> @@ -582,7 +582,7 @@ struct i915_vma *intel_guc_allocate_vma(struct intel_guc *guc, u32 size)
>   	u64 flags;
>   	int ret;
>   
> -	obj = i915_gem_object_create_shmem(gt->i915, size);
> +	obj = i915_gem_object_create_internal(gt->i915, size);
>   	if (IS_ERR(obj))
>   		return ERR_CAST(obj);
>   
>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
index 83f2c197375f..d66f8f9c5654 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
@@ -582,7 +582,7 @@  struct i915_vma *intel_guc_allocate_vma(struct intel_guc *guc, u32 size)
 	u64 flags;
 	int ret;
 
-	obj = i915_gem_object_create_shmem(gt->i915, size);
+	obj = i915_gem_object_create_internal(gt->i915, size);
 	if (IS_ERR(obj))
 		return ERR_CAST(obj);