From patchwork Thu Jul 18 09:02:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksandr Suvorov X-Patchwork-Id: 11048887 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 08B1813AC for ; Thu, 18 Jul 2019 12:12:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB3BF285C7 for ; Thu, 18 Jul 2019 12:12:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DF82A28820; Thu, 18 Jul 2019 12:12:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8911D28717 for ; Thu, 18 Jul 2019 12:12:07 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 83E9C1692; Thu, 18 Jul 2019 11:04:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 83E9C1692 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1563440723; bh=ueqK+gk0cgBtGygsxHhdfiRgh6Q8HeB+7wUnufh527A=; h=From:To:Date:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DfNKN8eRWcBkgNPx2HYjgoSqeRInli/edp2/K32u1QvfnXt5UzVUaH3C7HVktjhaa XUvuIeBnE5mS7J8sc8dQ3HM9tfYAomqxNIbUg6y4ZW+3XO54C2lvGyWu46hAfve+1p 3or7+zzSKcVLu8YslnU+QXsOriFJGVc0imPGkw20= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C37C1F803D5; Thu, 18 Jul 2019 11:02:57 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id 09B87F803A6; Thu, 18 Jul 2019 11:02:54 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40095.outbound.protection.outlook.com [40.107.4.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D4980F80362 for ; Thu, 18 Jul 2019 11:02:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D4980F80362 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=toradex.com header.i=@toradex.com header.b="f3W/puXc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lw5Ydb9hTIusn9jzjav3CYJXkGQfte92NHVhVoSuLFmJ4O3OVC6Lkk60pG8JQGSbiS3z7NkteClfHDEJHRIpP7Q74VmfXa1TiAaSmQ5V8nvuiNGCTyRW0xR63CHbJUcDgNLUzTmLAf7hT2A9s74Otx9HnwEp4w6kX8I5AVPtmT6LcrDPJQqlQQU10qYTshkcMQ0t2ej18U2Gf5wPLk7Yv6TTnXZm8EE6HiMb1RQIvD19YqSpzZ3DuXJY0vd8Hku/lQcdsXwLg/eSDDDAW4uCW256v/gcUgqIE44FsT/OZFAeJQpL5zOw5LQYmo2bSh8xmGMPhzfvdkYmHFawNGIdLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KENG8EsMsbygLILn6kmKiGP20I0vqpVPRW9K7S5YINc=; b=Lb+aBs7pZo3gDvr3NXVnnahm3BDxDAC/gLwrkSjsvOFUd5HdnkCtySb6D5QHXr/X1XlPmY04/XmKRPplM/yzRsmCnNPbjwkHCUtdbPmdBpqSHQk8Cq40tQX/EM+9YW/zoxZIrglZA9mBX4sYsQ0o/srvTaQvYFK7rufEbEJTv+Yi3udns6whpBQVZESNn0RZq+rdIhuxt24N5YBZNMo8xQgm5hikfehgJiTsuXvJKk6/DsRSeuk4zzUqgsfY1pINiJ+a3umkCQueo4r/j05H5TWn+LgvQOLCqD5jjgpWc4DRj6nsoHO5EV7qd4BfPYbFsjO9RghGrEASUj8tZ9zEOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=toradex.com;dmarc=pass action=none header.from=toradex.com;dkim=pass header.d=toradex.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toradex.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KENG8EsMsbygLILn6kmKiGP20I0vqpVPRW9K7S5YINc=; b=f3W/puXc6OUJpl84Lz98+KP9rmDAXJ6QzfLE1rAiPWx4HppQBQTUprCujpmg/i7kb94komGELDQoKyKQXDuoP8/aURxgixRCSkgDGoz72LXnpMMcnZQVwG9CIEvMDY/dZuob2s/Fdyd4vKglN4bk86+j43oZ/kPSl4qYCkFPY+0= Received: from AM6PR05MB6535.eurprd05.prod.outlook.com (20.179.18.16) by AM6PR05MB5013.eurprd05.prod.outlook.com (20.177.35.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.12; Thu, 18 Jul 2019 09:02:49 +0000 Received: from AM6PR05MB6535.eurprd05.prod.outlook.com ([fe80::c860:b386:22a:8ec9]) by AM6PR05MB6535.eurprd05.prod.outlook.com ([fe80::c860:b386:22a:8ec9%6]) with mapi id 15.20.2094.011; Thu, 18 Jul 2019 09:02:49 +0000 From: Oleksandr Suvorov To: Fabio Estevam Thread-Topic: [PATCH v5 3/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control Thread-Index: AQHVPUeSMC+aACEaGUiWMvIQp2qocw== Date: Thu, 18 Jul 2019 09:02:49 +0000 Message-ID: <20190718090240.18432-4-oleksandr.suvorov@toradex.com> References: <20190718090240.18432-1-oleksandr.suvorov@toradex.com> In-Reply-To: <20190718090240.18432-1-oleksandr.suvorov@toradex.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM3PR04CA0139.eurprd04.prod.outlook.com (2603:10a6:207::23) To AM6PR05MB6535.eurprd05.prod.outlook.com (2603:10a6:20b:71::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=oleksandr.suvorov@toradex.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [194.105.145.90] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b6bc69d-304c-4eb0-948b-08d70b5eb520 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:AM6PR05MB5013; x-ms-traffictypediagnostic: AM6PR05MB5013: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2657; x-forefront-prvs: 01026E1310 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(4636009)(39850400004)(346002)(366004)(376002)(396003)(136003)(199004)(189003)(2616005)(99286004)(68736007)(476003)(446003)(50226002)(11346002)(486006)(86362001)(8936002)(81166006)(76176011)(81156014)(26005)(14454004)(4326008)(186003)(386003)(6506007)(316002)(102836004)(6916009)(54906003)(52116002)(36756003)(6486002)(6436002)(71190400001)(71200400001)(6512007)(25786009)(14444005)(66066001)(256004)(66946007)(64756008)(66476007)(66556008)(66446008)(1076003)(1411001)(5660300002)(8676002)(478600001)(7736002)(44832011)(6116002)(3846002)(305945005)(53936002)(2906002); DIR:OUT; SFP:1102; SCL:1; SRVR:AM6PR05MB5013; H:AM6PR05MB6535.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: toradex.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: IC+hQCehtd+T9XcUNZfEE+IHJ5zkurSvijpuwOe7YL+d4F1k+SxGGa7JCBVGelBaasX3GuJFc2MCJ4M+VrmT74mNLtpPYvCW2wqsQh/ubgKp9bRYjQTfMJiZTc/ki9OUbSkM3wxzFpkLNTsbD8YJmkDu3S9eQ2jsRsXrdRy6unXz35Bfz+kaQ76IbZ7TZxp492UsUd2v9sKsIYDkU7rAxBt+9xFBpv8oUjRo/t60FPObi8nHyh9NCGucN+ZGuBOo6ecEmtE2qKFIjvyrXlBxggXqUaOsratqpYpC/aKkQX25uWy6OUL5bocW3ybK/vC5inVdz1qMENCqs69untCnNmAEXWBcxw3XvbI2pQwFXvd8jWOZWtP1o0zvxCFZx13XsWqC9Po+hvPMpa1P6XaZaHyrtT+JqBiZaJ7uHcli5qU= MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b6bc69d-304c-4eb0-948b-08d70b5eb520 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2019 09:02:49.0946 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oleksandr.suvorov@toradex.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5013 Cc: Igor Opaniuk , "alsa-devel@alsa-project.org" , Liam Girdwood , Marcel Ziswiler , Takashi Iwai , "linux-kernel@vger.kernel.org" , Oleksandr Suvorov , Mark Brown Subject: [alsa-devel] [PATCH v5 3/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" X-Virus-Scanned: ClamAV using ClamSMTP SGTL5000_SMALL_POP is a bit mask, not a value. Usage of correct definition makes device probing code more clear. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: - Fix patch formatting sound/soc/codecs/sgtl5000.c | 2 +- sound/soc/codecs/sgtl5000.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index a2aeb5fb9b537..a8d55c21a5f2d 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -1450,7 +1450,7 @@ static int sgtl5000_probe(struct snd_soc_component *component) /* enable small pop, introduce 400ms delay in turning off */ snd_soc_component_update_bits(component, SGTL5000_CHIP_REF_CTRL, - SGTL5000_SMALL_POP, 1); + SGTL5000_SMALL_POP, SGTL5000_SMALL_POP); /* disable short cut detector */ snd_soc_component_write(component, SGTL5000_CHIP_SHORT_CTRL, 0); diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h index 18cae08bbd3a6..a4bf4bca95bf7 100644 --- a/sound/soc/codecs/sgtl5000.h +++ b/sound/soc/codecs/sgtl5000.h @@ -273,7 +273,7 @@ #define SGTL5000_BIAS_CTRL_MASK 0x000e #define SGTL5000_BIAS_CTRL_SHIFT 1 #define SGTL5000_BIAS_CTRL_WIDTH 3 -#define SGTL5000_SMALL_POP 1 +#define SGTL5000_SMALL_POP 0x0001 /* * SGTL5000_CHIP_MIC_CTRL