USB Modem support for Droid 4
diff mbox series

Message ID 20190718201713.GA25103@amd
State New
Headers show
Series
  • USB Modem support for Droid 4
Related show

Commit Message

Pavel Machek July 18, 2019, 8:17 p.m. UTC
From: Tony Lindgren <tony@atomide.com>

Droid starts to have useful support in linux-next. Modem is tricky to
play with, but this is enough to get basic support.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

Comments

Tony Lindgren July 19, 2019, 5:22 a.m. UTC | #1
Hi,

* Pavel Machek <pavel@denx.de> [190718 20:17]:
> From: Tony Lindgren <tony@atomide.com>
> 
> Droid starts to have useful support in linux-next. Modem is tricky to
> play with, but this is enough to get basic support.

Below is a better patch using option driver adding support for all
the ports. I'll send it out with a proper description after -rc1.

Regards,

Tony

8< ----------------
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -83,6 +83,12 @@ static void option_instat_callback(struct urb *urb);
 #define HUAWEI_PRODUCT_K4605			0x14C6
 #define HUAWEI_PRODUCT_E173S6			0x1C07
 
+#define MOTOROLA_VENDOR_ID			0x22b8
+#define MOTOROLA_PRODUCT_MDM6600		0x2a70
+#define MOTOROLA_PRODUCT_MDM9600		0x2e0a
+#define MOTOROLA_PRODUCT_MDM_RAM_DL		0x4281
+#define MOTOROLA_PRODUCT_MDM_QC_DL		0x900e
+
 #define QUANTA_VENDOR_ID			0x0408
 #define QUANTA_PRODUCT_Q101			0xEA02
 #define QUANTA_PRODUCT_Q111			0xEA03
@@ -968,6 +974,10 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_VENDOR_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0xff, 0x06, 0x7B) },
 	{ USB_VENDOR_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0xff, 0x06, 0x7C) },
 
+	{ USB_DEVICE_AND_INTERFACE_INFO(MOTOROLA_VENDOR_ID, MOTOROLA_PRODUCT_MDM6600, 0xff, 0xff, 0xff) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MOTOROLA_VENDOR_ID, MOTOROLA_PRODUCT_MDM9600, 0xff, 0xff, 0xff) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MOTOROLA_VENDOR_ID, MOTOROLA_PRODUCT_MDM_RAM_DL, 0x0a, 0x00, 0xfc) },
+	{ USB_DEVICE_AND_INTERFACE_INFO(MOTOROLA_VENDOR_ID, MOTOROLA_PRODUCT_MDM_QC_DL, 0xff, 0xff, 0xff) },
 
 	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V640) },
 	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V620) },
Pavel Machek July 19, 2019, 10:11 a.m. UTC | #2
Hi!

> * Pavel Machek <pavel@denx.de> [190718 20:17]:
> > From: Tony Lindgren <tony@atomide.com>
> > 
> > Droid starts to have useful support in linux-next. Modem is tricky to
> > play with, but this is enough to get basic support.
> 
> Below is a better patch using option driver adding support for all
> the ports. I'll send it out with a proper description after -rc1.

Thanks!

It works for me, too.

Tested-by: Pavel Machek <pavel@ucw.cz>

> @@ -83,6 +83,12 @@ static void option_instat_callback(struct urb *urb);
>  #define HUAWEI_PRODUCT_K4605			0x14C6
>  #define HUAWEI_PRODUCT_E173S6			0x1C07
>  
> +#define MOTOROLA_VENDOR_ID			0x22b8
> +#define MOTOROLA_PRODUCT_MDM6600		0x2a70
> +#define MOTOROLA_PRODUCT_MDM9600		0x2e0a
> +#define MOTOROLA_PRODUCT_MDM_RAM_DL		0x4281
> +#define MOTOROLA_PRODUCT_MDM_QC_DL		0x900e
> +
>  #define QUANTA_VENDOR_ID			0x0408
>  #define QUANTA_PRODUCT_Q101			0xEA02
>  #define QUANTA_PRODUCT_Q111			0xEA03
> @@ -968,6 +974,10 @@ static const struct usb_device_id option_ids[] = {
>  	{ USB_VENDOR_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0xff, 0x06, 0x7B) },
>  	{ USB_VENDOR_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, 0xff, 0x06, 0x7C) },
>  
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MOTOROLA_VENDOR_ID, MOTOROLA_PRODUCT_MDM6600, 0xff, 0xff, 0xff) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MOTOROLA_VENDOR_ID, MOTOROLA_PRODUCT_MDM9600, 0xff, 0xff, 0xff) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MOTOROLA_VENDOR_ID, MOTOROLA_PRODUCT_MDM_RAM_DL, 0x0a, 0x00, 0xfc) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(MOTOROLA_VENDOR_ID, MOTOROLA_PRODUCT_MDM_QC_DL, 0xff, 0xff, 0xff) },
>  
>  	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V640) },
>  	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V620) },
Greg Kroah-Hartman July 19, 2019, 10:27 a.m. UTC | #3
On Thu, Jul 18, 2019 at 10:17:13PM +0200, Pavel Machek wrote:
> From: Tony Lindgren <tony@atomide.com>
> 
> Droid starts to have useful support in linux-next. Modem is tricky to
> play with, but this is enough to get basic support.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

No signed-off-by from Tony?

And no [PATCH] in the subject?

odd...
Pavel Machek July 21, 2019, 4:20 p.m. UTC | #4
On Fri 2019-07-19 19:27:48, Greg KH wrote:
> On Thu, Jul 18, 2019 at 10:17:13PM +0200, Pavel Machek wrote:
> > From: Tony Lindgren <tony@atomide.com>
> > 
> > Droid starts to have useful support in linux-next. Modem is tricky to
> > play with, but this is enough to get basic support.
> > 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> No signed-off-by from Tony?
> 
> And no [PATCH] in the subject?

I was relaying patch. You'll get better one directly from Tony,
"soon". :-)

Best regards,							Pavel

Patch
diff mbox series

diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 613f91a..3ca9439 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -181,6 +181,9 @@  static const struct usb_device_id id_table[] = {
 	/* Huawei devices */
 	{DEVICE_HWI(0x03f0, 0x581d)},	/* HP lt4112 LTE/HSPA+ Gobi 4G Modem (Huawei me906e) */
 
+	/* Motorola devices */
+	{DEVICE_HWI(0x22b8, 0x2a70)},	/* Droid 4 mdm6600 */
+
 	{ }				/* Terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, id_table);