[1/2] Revert "drm/i915/guc: Turn on GuC/HuC auto mode"
diff mbox series

Message ID 20190719094845.6242-2-tvrtko.ursulin@linux.intel.com
State New
Headers show
Series
  • Revert GuC by default
Related show

Commit Message

Tvrtko Ursulin July 19, 2019, 9:48 a.m. UTC
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4.

If GuC firmware is not present on the filesystem driver crashes the
machine on boot.

Fixes: f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
---
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniele Ceraolo Spurio July 19, 2019, 3:50 p.m. UTC | #1
On 7/19/19 2:48 AM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4.
> 
> If GuC firmware is not present on the filesystem driver crashes the
> machine on boot.
> 

Do you have a log? I can't reproduce this on a SKL, I'm just getting:

[55667.026707] i915 0000:00:02.0: Direct firmware load for 
i915/skl_guc_33.0.0.bin failed with error -2
[55667.026714] [drm] GuC: Failed to fetch firmware 
i915/skl_guc_33.0.0.bin (error -2)
[55667.026717] [drm] GuC: Firmware can be downloaded from 
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/i915
[55667.081885] i915 0000:00:02.0: Device initialization failed (-8)
[55667.081949] i915: probe of 0000:00:02.0 failed with error -8


This is on the latest tip (just fetched).

Daniele

> Fixes: f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> ---
>   drivers/gpu/drm/i915/i915_params.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index 5736c55694fe..d29ade3b7de6 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -54,7 +54,7 @@ struct drm_printer;
>   	param(int, disable_power_well, -1) \
>   	param(int, enable_ips, 1) \
>   	param(int, invert_brightness, 0) \
> -	param(int, enable_guc, -1) \
> +	param(int, enable_guc, 0) \
>   	param(int, guc_log_level, -1) \
>   	param(char *, guc_firmware_path, NULL) \
>   	param(char *, huc_firmware_path, NULL) \
>
Daniele Ceraolo Spurio July 19, 2019, 3:54 p.m. UTC | #2
On 7/19/19 8:50 AM, Daniele Ceraolo Spurio wrote:
> 
> 
> On 7/19/19 2:48 AM, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4.
>>
>> If GuC firmware is not present on the filesystem driver crashes the
>> machine on boot.
>>
> 
> Do you have a log? I can't reproduce this on a SKL, I'm just getting:
> 
> [55667.026707] i915 0000:00:02.0: Direct firmware load for 
> i915/skl_guc_33.0.0.bin failed with error -2
> [55667.026714] [drm] GuC: Failed to fetch firmware 
> i915/skl_guc_33.0.0.bin (error -2)
> [55667.026717] [drm] GuC: Firmware can be downloaded from 
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/i915 
> 
> [55667.081885] i915 0000:00:02.0: Device initialization failed (-8)
> [55667.081949] i915: probe of 0000:00:02.0 failed with error -8
> 
> 
> This is on the latest tip (just fetched).
> 
> Daniele
> 

Found your cover letter with the links to the logs in  my spam folder 
(damn filter!), please ignore the above request.

Daniele

>> Fixes: f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: intel-gfx@lists.freedesktop.org
>> ---
>>   drivers/gpu/drm/i915/i915_params.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_params.h 
>> b/drivers/gpu/drm/i915/i915_params.h
>> index 5736c55694fe..d29ade3b7de6 100644
>> --- a/drivers/gpu/drm/i915/i915_params.h
>> +++ b/drivers/gpu/drm/i915/i915_params.h
>> @@ -54,7 +54,7 @@ struct drm_printer;
>>       param(int, disable_power_well, -1) \
>>       param(int, enable_ips, 1) \
>>       param(int, invert_brightness, 0) \
>> -    param(int, enable_guc, -1) \
>> +    param(int, enable_guc, 0) \
>>       param(int, guc_log_level, -1) \
>>       param(char *, guc_firmware_path, NULL) \
>>       param(char *, huc_firmware_path, NULL) \
>>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin July 19, 2019, 3:56 p.m. UTC | #3
On 19/07/2019 16:50, Daniele Ceraolo Spurio wrote:
> 
> 
> On 7/19/19 2:48 AM, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> This reverts commit f774f09649192f326fa030564afd3f8f5d82c1e4.
>>
>> If GuC firmware is not present on the filesystem driver crashes the
>> machine on boot.
>>
> 
> Do you have a log? I can't reproduce this on a SKL, I'm just getting:

Links are in the cover letter. The boot log does not show a crash but 
ends suspiciously and all Icelakes in BAT were reported missing from the 
test run.

Regards,

Tvrtko

> [55667.026707] i915 0000:00:02.0: Direct firmware load for 
> i915/skl_guc_33.0.0.bin failed with error -2
> [55667.026714] [drm] GuC: Failed to fetch firmware 
> i915/skl_guc_33.0.0.bin (error -2)
> [55667.026717] [drm] GuC: Firmware can be downloaded from 
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/i915 
> 
> [55667.081885] i915 0000:00:02.0: Device initialization failed (-8)
> [55667.081949] i915: probe of 0000:00:02.0 failed with error -8
> 
> 
> This is on the latest tip (just fetched).
> 
> Daniele
> 
>> Fixes: f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: intel-gfx@lists.freedesktop.org
>> ---
>>   drivers/gpu/drm/i915/i915_params.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_params.h 
>> b/drivers/gpu/drm/i915/i915_params.h
>> index 5736c55694fe..d29ade3b7de6 100644
>> --- a/drivers/gpu/drm/i915/i915_params.h
>> +++ b/drivers/gpu/drm/i915/i915_params.h
>> @@ -54,7 +54,7 @@ struct drm_printer;
>>       param(int, disable_power_well, -1) \
>>       param(int, enable_ips, 1) \
>>       param(int, invert_brightness, 0) \
>> -    param(int, enable_guc, -1) \
>> +    param(int, enable_guc, 0) \
>>       param(int, guc_log_level, -1) \
>>       param(char *, guc_firmware_path, NULL) \
>>       param(char *, huc_firmware_path, NULL) \
>>
>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index 5736c55694fe..d29ade3b7de6 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -54,7 +54,7 @@  struct drm_printer;
 	param(int, disable_power_well, -1) \
 	param(int, enable_ips, 1) \
 	param(int, invert_brightness, 0) \
-	param(int, enable_guc, -1) \
+	param(int, enable_guc, 0) \
 	param(int, guc_log_level, -1) \
 	param(char *, guc_firmware_path, NULL) \
 	param(char *, huc_firmware_path, NULL) \