| Message ID | 20190719131425.10835-3-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Trivial switch 'fall through' comment fixes for GCC9 | expand |
On Fri, 19 Jul 2019 at 14:14, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: > > CC hw/dma/omap_dma.o > hw/dma/omap_dma.c: In function ‘omap_dma_write’: > hw/dma/omap_dma.c:1532:12: error: this statement may fall through [-Werror=implicit-fallthrough=] > 1532 | if (s->model <= omap_dma_3_1) > | ^ > hw/dma/omap_dma.c:1534:5: note: here > 1534 | case 0x400: > | ^~~~ > cc1: all warnings being treated as errors > > Correctly place the 'fall through' comment. > > Reported-by: Stefan Weil <sw@weilnetz.de> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/dma/omap_dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/dma/omap_dma.c b/hw/dma/omap_dma.c > index eab83c5c3a..6677237d42 100644 > --- a/hw/dma/omap_dma.c > +++ b/hw/dma/omap_dma.c > @@ -1531,8 +1531,8 @@ static void omap_dma_write(void *opaque, hwaddr addr, > case 0x404 ... 0x4fe: > if (s->model <= omap_dma_3_1) > break; > + /* fall through */ > case 0x400: > - /* Fall through. */ > if (omap_dma_sys_write(s, addr, value)) > break; > return; > - Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
Le 19/07/2019 à 15:14, Philippe Mathieu-Daudé a écrit : > Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: > > CC hw/dma/omap_dma.o > hw/dma/omap_dma.c: In function ‘omap_dma_write’: > hw/dma/omap_dma.c:1532:12: error: this statement may fall through [-Werror=implicit-fallthrough=] > 1532 | if (s->model <= omap_dma_3_1) > | ^ > hw/dma/omap_dma.c:1534:5: note: here > 1534 | case 0x400: > | ^~~~ > cc1: all warnings being treated as errors > > Correctly place the 'fall through' comment. > > Reported-by: Stefan Weil <sw@weilnetz.de> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/dma/omap_dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/dma/omap_dma.c b/hw/dma/omap_dma.c > index eab83c5c3a..6677237d42 100644 > --- a/hw/dma/omap_dma.c > +++ b/hw/dma/omap_dma.c > @@ -1531,8 +1531,8 @@ static void omap_dma_write(void *opaque, hwaddr addr, > case 0x404 ... 0x4fe: > if (s->model <= omap_dma_3_1) > break; > + /* fall through */ > case 0x400: > - /* Fall through. */ > if (omap_dma_sys_write(s, addr, value)) > break; > return; > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/hw/dma/omap_dma.c b/hw/dma/omap_dma.c index eab83c5c3a..6677237d42 100644 --- a/hw/dma/omap_dma.c +++ b/hw/dma/omap_dma.c @@ -1531,8 +1531,8 @@ static void omap_dma_write(void *opaque, hwaddr addr, case 0x404 ... 0x4fe: if (s->model <= omap_dma_3_1) break; + /* fall through */ case 0x400: - /* Fall through. */ if (omap_dma_sys_write(s, addr, value)) break; return;
Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: CC hw/dma/omap_dma.o hw/dma/omap_dma.c: In function ‘omap_dma_write’: hw/dma/omap_dma.c:1532:12: error: this statement may fall through [-Werror=implicit-fallthrough=] 1532 | if (s->model <= omap_dma_3_1) | ^ hw/dma/omap_dma.c:1534:5: note: here 1534 | case 0x400: | ^~~~ cc1: all warnings being treated as errors Correctly place the 'fall through' comment. Reported-by: Stefan Weil <sw@weilnetz.de> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/dma/omap_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)