[PULL] gvt-fixes
mbox series

Message ID 20190723092958.GD8319@zhen-hp.sh.intel.com
State New
Headers show
Series
  • [PULL] gvt-fixes
Related show

Pull-request

https://github.com/intel/gvt-linux.git tags/gvt-fixes-2019-07-23

Message

Zhenyu Wang July 23, 2019, 9:29 a.m. UTC
Hi,

Here's recent gvt-fixes for 5.3-rc. It includes safety guard
for possible ggtt access error with related checks, includecheck
fix and one cache entry size fix for 2MB ppgtt guest.

Thanks.
--
The following changes since commit d7e8a19b38c8ac1a32b6b03af049e2c88d4155db:

  drm/i915: Don't dereference request if it may have been retired when printing (2019-07-09 16:16:18 +0300)

are available in the Git repository at:

  https://github.com/intel/gvt-linux.git tags/gvt-fixes-2019-07-23

for you to fetch changes up to 8642656299cf86cfeceb1a48b0e1874de6874a2b:

  drm/i915/gvt: fix incorrect cache entry for guest page mapping (2019-07-18 11:06:41 +0800)

----------------------------------------------------------------
gvt-fixes-2019-07-23

- Guard against potential ggtt access error (Xiong)
- Fix includecheck (Zhenyu)
- Fix cache entry for guest page mapping found by 2M ppgtt guest (Xiaolin)

----------------------------------------------------------------
Xiaolin Zhang (1):
      drm/i915/gvt: fix incorrect cache entry for guest page mapping

Xiong Zhang (3):
      drm/i915/gvt: Warning for invalid ggtt access
      drm/i915/gvt: Don't use ggtt_validdate_range() with size=0
      drm/i915/gvt: Checking workload's gma earlier

Zhenyu Wang (1):
      drm/i915/gvt: remove duplicate include of trace.h

 drivers/gpu/drm/i915/gvt/cmd_parser.c   | 10 ----------
 drivers/gpu/drm/i915/gvt/fb_decoder.c   |  6 +++---
 drivers/gpu/drm/i915/gvt/gtt.c          |  9 +++++++++
 drivers/gpu/drm/i915/gvt/kvmgt.c        | 12 ++++++++++++
 drivers/gpu/drm/i915/gvt/scheduler.c    | 28 ++++++++++++++++++++++++++++
 drivers/gpu/drm/i915/gvt/trace_points.c |  2 --
 6 files changed, 52 insertions(+), 15 deletions(-)

Comments

Zhenyu Wang July 29, 2019, 3:33 a.m. UTC | #1
ping..

On 2019.07.23 17:29:58 +0800, Zhenyu Wang wrote:
> 
> Hi,
> 
> Here's recent gvt-fixes for 5.3-rc. It includes safety guard
> for possible ggtt access error with related checks, includecheck
> fix and one cache entry size fix for 2MB ppgtt guest.
> 
> Thanks.
> --
> The following changes since commit d7e8a19b38c8ac1a32b6b03af049e2c88d4155db:
> 
>   drm/i915: Don't dereference request if it may have been retired when printing (2019-07-09 16:16:18 +0300)
> 
> are available in the Git repository at:
> 
>   https://github.com/intel/gvt-linux.git tags/gvt-fixes-2019-07-23
> 
> for you to fetch changes up to 8642656299cf86cfeceb1a48b0e1874de6874a2b:
> 
>   drm/i915/gvt: fix incorrect cache entry for guest page mapping (2019-07-18 11:06:41 +0800)
> 
> ----------------------------------------------------------------
> gvt-fixes-2019-07-23
> 
> - Guard against potential ggtt access error (Xiong)
> - Fix includecheck (Zhenyu)
> - Fix cache entry for guest page mapping found by 2M ppgtt guest (Xiaolin)
> 
> ----------------------------------------------------------------
> Xiaolin Zhang (1):
>       drm/i915/gvt: fix incorrect cache entry for guest page mapping
> 
> Xiong Zhang (3):
>       drm/i915/gvt: Warning for invalid ggtt access
>       drm/i915/gvt: Don't use ggtt_validdate_range() with size=0
>       drm/i915/gvt: Checking workload's gma earlier
> 
> Zhenyu Wang (1):
>       drm/i915/gvt: remove duplicate include of trace.h
> 
>  drivers/gpu/drm/i915/gvt/cmd_parser.c   | 10 ----------
>  drivers/gpu/drm/i915/gvt/fb_decoder.c   |  6 +++---
>  drivers/gpu/drm/i915/gvt/gtt.c          |  9 +++++++++
>  drivers/gpu/drm/i915/gvt/kvmgt.c        | 12 ++++++++++++
>  drivers/gpu/drm/i915/gvt/scheduler.c    | 28 ++++++++++++++++++++++++++++
>  drivers/gpu/drm/i915/gvt/trace_points.c |  2 --
>  6 files changed, 52 insertions(+), 15 deletions(-)
> 
> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827



> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
Jani Nikula July 29, 2019, 11:05 a.m. UTC | #2
On Mon, 29 Jul 2019, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> ping..

Sorry for the delay. Unfortunately, dim hit the following issues:

Pulling https://github.com/intel/gvt-linux.git tags/gvt-fixes-2019-07-23 ...
From https://github.com/intel/gvt-linux
 * tag                         gvt-fixes-2019-07-23 -> FETCH_HEAD
dim: 8642656299cf ("drm/i915/gvt: fix incorrect cache entry for guest page mapping"): committer Signed-off-by missing.
dim: 4c2bb55ba7d6 ("drm/i915/gvt: remove duplicate include of trace.h"): mandatory review missing.
dim: 25fd1829ae4e ("drm/i915: Make the semaphore saturation mask global"): Fixes: SHA1 in not pointing at an ancestor:
dim:     ca6e56f654e7 ("drm/i915: Disable semaphore busywaits on saturated systems")
dim: ERROR: issues in commits detected, aborting

Please fix, and make it a habit to run the checks before sending the
pull requests.

BR,
Jani.



>
> On 2019.07.23 17:29:58 +0800, Zhenyu Wang wrote:
>> 
>> Hi,
>> 
>> Here's recent gvt-fixes for 5.3-rc. It includes safety guard
>> for possible ggtt access error with related checks, includecheck
>> fix and one cache entry size fix for 2MB ppgtt guest.
>> 
>> Thanks.
>> --
>> The following changes since commit d7e8a19b38c8ac1a32b6b03af049e2c88d4155db:
>> 
>>   drm/i915: Don't dereference request if it may have been retired when printing (2019-07-09 16:16:18 +0300)
>> 
>> are available in the Git repository at:
>> 
>>   https://github.com/intel/gvt-linux.git tags/gvt-fixes-2019-07-23
>> 
>> for you to fetch changes up to 8642656299cf86cfeceb1a48b0e1874de6874a2b:
>> 
>>   drm/i915/gvt: fix incorrect cache entry for guest page mapping (2019-07-18 11:06:41 +0800)
>> 
>> ----------------------------------------------------------------
>> gvt-fixes-2019-07-23
>> 
>> - Guard against potential ggtt access error (Xiong)
>> - Fix includecheck (Zhenyu)
>> - Fix cache entry for guest page mapping found by 2M ppgtt guest (Xiaolin)
>> 
>> ----------------------------------------------------------------
>> Xiaolin Zhang (1):
>>       drm/i915/gvt: fix incorrect cache entry for guest page mapping
>> 
>> Xiong Zhang (3):
>>       drm/i915/gvt: Warning for invalid ggtt access
>>       drm/i915/gvt: Don't use ggtt_validdate_range() with size=0
>>       drm/i915/gvt: Checking workload's gma earlier
>> 
>> Zhenyu Wang (1):
>>       drm/i915/gvt: remove duplicate include of trace.h
>> 
>>  drivers/gpu/drm/i915/gvt/cmd_parser.c   | 10 ----------
>>  drivers/gpu/drm/i915/gvt/fb_decoder.c   |  6 +++---
>>  drivers/gpu/drm/i915/gvt/gtt.c          |  9 +++++++++
>>  drivers/gpu/drm/i915/gvt/kvmgt.c        | 12 ++++++++++++
>>  drivers/gpu/drm/i915/gvt/scheduler.c    | 28 ++++++++++++++++++++++++++++
>>  drivers/gpu/drm/i915/gvt/trace_points.c |  2 --
>>  6 files changed, 52 insertions(+), 15 deletions(-)
>> 
>> -- 
>> Open Source Technology Center, Intel ltd.
>> 
>> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
>
>
>
>> _______________________________________________
>> intel-gvt-dev mailing list
>> intel-gvt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
Zhenyu Wang July 30, 2019, 7 a.m. UTC | #3
On 2019.07.29 14:05:05 +0300, Jani Nikula wrote:
> 
> Please fix, and make it a habit to run the checks before sending the
> pull requests.
> 

Sorry for that! I've tried to refresh and regenerate the pull. This also
brings in two more fixes in queue, one for runtime pm warning fix and another
one for windows guest TDR reset fix.

Thanks.
--
The following changes since commit 89f5752307cf53010d97503ac501b2ca1b089922:

  drm/i915: Fix the TBT AUX power well enabling (2019-07-29 15:54:37 +0300)

are available in the Git repository at:

  https://github.com/intel/gvt-linux.git tags/gvt-fixes-2019-07-30

for you to fetch changes up to 4187414808095f645ca0661f8dde77617e2e7cb3:

  drm/i915/gvt: Adding ppgtt to GVT GEM context after shadow pdps settled. (2019-07-30 14:30:56 +0800)

----------------------------------------------------------------
gvt-fixes-2019-07-30

- Guard against potential ggtt access error (Xiong)
- Fix includecheck (Zhenyu)
- Fix cache entry for guest page mapping found by 2M ppgtt guest (Xiaolin)
- Fix runtime pm warning (Xiaolin)
- Fix shadow mm settlement for Windows guest reset failure (Colin)

----------------------------------------------------------------
Colin Xu (1):
      drm/i915/gvt: Adding ppgtt to GVT GEM context after shadow pdps settled.

Xiaolin Zhang (2):
      drm/i915/gvt: fix incorrect cache entry for guest page mapping
      drm/i915/gvt: grab runtime pm first for forcewake use

Xiong Zhang (3):
      drm/i915/gvt: Warning for invalid ggtt access
      drm/i915/gvt: Don't use ggtt_validdate_range() with size=0
      drm/i915/gvt: Checking workload's gma earlier

Zhenyu Wang (1):
      drm/i915/gvt: remove duplicate include of trace.h

 drivers/gpu/drm/i915/gvt/cmd_parser.c   | 10 ------
 drivers/gpu/drm/i915/gvt/fb_decoder.c   |  6 ++--
 drivers/gpu/drm/i915/gvt/gtt.c          |  9 +++++
 drivers/gpu/drm/i915/gvt/kvmgt.c        | 12 +++++++
 drivers/gpu/drm/i915/gvt/scheduler.c    | 59 ++++++++++++++++++++++++---------
 drivers/gpu/drm/i915/gvt/trace_points.c |  2 --
 6 files changed, 68 insertions(+), 30 deletions(-)
Jani Nikula July 30, 2019, 8:33 a.m. UTC | #4
On Tue, 30 Jul 2019, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> On 2019.07.29 14:05:05 +0300, Jani Nikula wrote:
>> 
>> Please fix, and make it a habit to run the checks before sending the
>> pull requests.
>> 
>
> Sorry for that! I've tried to refresh and regenerate the pull. This also
> brings in two more fixes in queue, one for runtime pm warning fix and another
> one for windows guest TDR reset fix.

Thanks, pulled & pushed!

BR,
Jani.



>
> Thanks.
> --
> The following changes since commit 89f5752307cf53010d97503ac501b2ca1b089922:
>
>   drm/i915: Fix the TBT AUX power well enabling (2019-07-29 15:54:37 +0300)
>
> are available in the Git repository at:
>
>   https://github.com/intel/gvt-linux.git tags/gvt-fixes-2019-07-30
>
> for you to fetch changes up to 4187414808095f645ca0661f8dde77617e2e7cb3:
>
>   drm/i915/gvt: Adding ppgtt to GVT GEM context after shadow pdps settled. (2019-07-30 14:30:56 +0800)
>
> ----------------------------------------------------------------
> gvt-fixes-2019-07-30
>
> - Guard against potential ggtt access error (Xiong)
> - Fix includecheck (Zhenyu)
> - Fix cache entry for guest page mapping found by 2M ppgtt guest (Xiaolin)
> - Fix runtime pm warning (Xiaolin)
> - Fix shadow mm settlement for Windows guest reset failure (Colin)
>
> ----------------------------------------------------------------
> Colin Xu (1):
>       drm/i915/gvt: Adding ppgtt to GVT GEM context after shadow pdps settled.
>
> Xiaolin Zhang (2):
>       drm/i915/gvt: fix incorrect cache entry for guest page mapping
>       drm/i915/gvt: grab runtime pm first for forcewake use
>
> Xiong Zhang (3):
>       drm/i915/gvt: Warning for invalid ggtt access
>       drm/i915/gvt: Don't use ggtt_validdate_range() with size=0
>       drm/i915/gvt: Checking workload's gma earlier
>
> Zhenyu Wang (1):
>       drm/i915/gvt: remove duplicate include of trace.h
>
>  drivers/gpu/drm/i915/gvt/cmd_parser.c   | 10 ------
>  drivers/gpu/drm/i915/gvt/fb_decoder.c   |  6 ++--
>  drivers/gpu/drm/i915/gvt/gtt.c          |  9 +++++
>  drivers/gpu/drm/i915/gvt/kvmgt.c        | 12 +++++++
>  drivers/gpu/drm/i915/gvt/scheduler.c    | 59 ++++++++++++++++++++++++---------
>  drivers/gpu/drm/i915/gvt/trace_points.c |  2 --
>  6 files changed, 68 insertions(+), 30 deletions(-)