| Message ID | 20190723112811.44381-3-tony@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ti-sysc related warning fixes for v5.3-rc cycle | expand |
+ Jyri On 7/23/19 6:28 AM, Tony Lindgren wrote: > We currently get a warning for lcdc because of a difference > with dts provided configuration compared to the legacy platform > data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in > the platform data without configuring the modes. Hi Tony, While I understand that you are trying to match the DT data with the existing legacy data, do you know if there was a reason why this was omitted in the first place? Should we be really adding the MSTANDBY_ flags and fix up the DTS node accordingly? I tried looking through the git log, and the initial commit itself didn't add the MSTANDBY_ flags but used the SYSC_HAS_MIDLEMODE. Jyri, Do you know the history? regards Suman > > Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that > the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { > static struct omap_hwmod_class_sysconfig lcdc_sysc = { > .rev_offs = 0x0, > .sysc_offs = 0x54, > - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), > + .sysc_flags = SYSC_HAS_SIDLEMODE, > .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), > .sysc_fields = &omap_hwmod_sysc_type2, > }; >
On 24/07/19 12:33 AM, Suman Anna wrote: > + Jyri > > On 7/23/19 6:28 AM, Tony Lindgren wrote: >> We currently get a warning for lcdc because of a difference >> with dts provided configuration compared to the legacy platform >> data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in >> the platform data without configuring the modes. > > Hi Tony, > While I understand that you are trying to match the DT data with the > existing legacy data, do you know if there was a reason why this was > omitted in the first place? Should we be really adding the MSTANDBY_ > flags and fix up the DTS node accordingly? I tried looking through the > git log, and the initial commit itself didn't add the MSTANDBY_ flags > but used the SYSC_HAS_MIDLEMODE. > > Jyri, > Do you know the history? Tony/Suman, This patch breaks DS0 on am3. - Keerthy > > regards > Suman > >> >> Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that >> the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. > > > >> >> Signed-off-by: Tony Lindgren <tony@atomide.com> >> --- >> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >> @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { >> static struct omap_hwmod_class_sysconfig lcdc_sysc = { >> .rev_offs = 0x0, >> .sysc_offs = 0x54, >> - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), >> + .sysc_flags = SYSC_HAS_SIDLEMODE, >> .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), >> .sysc_fields = &omap_hwmod_sysc_type2, >> }; >> >
* Keerthy <j-keerthy@ti.com> [190724 05:50]: > > On 24/07/19 12:33 AM, Suman Anna wrote: > > + Jyri > > > > On 7/23/19 6:28 AM, Tony Lindgren wrote: > > > We currently get a warning for lcdc because of a difference > > > with dts provided configuration compared to the legacy platform > > > data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in > > > the platform data without configuring the modes. > > > > Hi Tony, > > While I understand that you are trying to match the DT data with the > > existing legacy data, do you know if there was a reason why this was > > omitted in the first place? Should we be really adding the MSTANDBY_ > > flags and fix up the DTS node accordingly? I tried looking through the > > git log, and the initial commit itself didn't add the MSTANDBY_ flags > > but used the SYSC_HAS_MIDLEMODE. Yes the goal is to get rid of all errors and warnings in dmesg output so we can spot the real issues. > > Jyri, > > Do you know the history? > > Tony/Suman, > > This patch breaks DS0 on am3. OK thanks for testing. Let's drop this for now, sounds like there is some midlemode configuration happening even with no flags set. Probably the right fix is to configure the usable midlemodes instead both for platform data and dts data and then drop the platform data. Regards, Tony > > > Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that > > > the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. > > > > > > > > > > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > > --- > > > arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c > > > @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { > > > static struct omap_hwmod_class_sysconfig lcdc_sysc = { > > > .rev_offs = 0x0, > > > .sysc_offs = 0x54, > > > - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), > > > + .sysc_flags = SYSC_HAS_SIDLEMODE, > > > .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), > > > .sysc_fields = &omap_hwmod_sysc_type2, > > > }; > > > > >
On 7/24/19 1:31 AM, Tony Lindgren wrote: > * Keerthy <j-keerthy@ti.com> [190724 05:50]: >> >> On 24/07/19 12:33 AM, Suman Anna wrote: >>> + Jyri >>> >>> On 7/23/19 6:28 AM, Tony Lindgren wrote: >>>> We currently get a warning for lcdc because of a difference >>>> with dts provided configuration compared to the legacy platform >>>> data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in >>>> the platform data without configuring the modes. >>> >>> Hi Tony, >>> While I understand that you are trying to match the DT data with the >>> existing legacy data, do you know if there was a reason why this was >>> omitted in the first place? Should we be really adding the MSTANDBY_ >>> flags and fix up the DTS node accordingly? I tried looking through the >>> git log, and the initial commit itself didn't add the MSTANDBY_ flags >>> but used the SYSC_HAS_MIDLEMODE. > > Yes the goal is to get rid of all errors and warnings in dmesg output > so we can spot the real issues. > >>> Jyri, >>> Do you know the history? >> >> Tony/Suman, >> >> This patch breaks DS0 on am3. > > OK thanks for testing. Let's drop this for now, sounds like there is > some midlemode configuration happening even with no flags set. You were dropping the ti,sysc-midle property in patch 8, is that still ok without this patch? > > Probably the right fix is to configure the usable midlemodes instead > both for platform data and dts data and then drop the platform data. Yeah, that's probably better and more accurate unless we actually have some h/w issues that require them to be dropped. regards Suman > > Regards, > > Tony > > > >>>> Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that >>>> the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. >>> >>> >>> >>>> >>>> Signed-off-by: Tony Lindgren <tony@atomide.com> >>>> --- >>>> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >>>> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >>>> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >>>> @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { >>>> static struct omap_hwmod_class_sysconfig lcdc_sysc = { >>>> .rev_offs = 0x0, >>>> .sysc_offs = 0x54, >>>> - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), >>>> + .sysc_flags = SYSC_HAS_SIDLEMODE, >>>> .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), >>>> .sysc_fields = &omap_hwmod_sysc_type2, >>>> }; >>>> >>>
* Suman Anna <s-anna@ti.com> [190724 18:29]: > On 7/24/19 1:31 AM, Tony Lindgren wrote: > > OK thanks for testing. Let's drop this for now, sounds like there is > > some midlemode configuration happening even with no flags set. > > You were dropping the ti,sysc-midle property in patch 8, is that still > ok without this patch? Yeah let's wait on that one too until we hear back from Jyri. Regards, Tony
On 23/07/2019 22:03, Suman Anna wrote: > + Jyri > > On 7/23/19 6:28 AM, Tony Lindgren wrote: >> We currently get a warning for lcdc because of a difference >> with dts provided configuration compared to the legacy platform >> data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in >> the platform data without configuring the modes. > > Hi Tony, > While I understand that you are trying to match the DT data with the > existing legacy data, do you know if there was a reason why this was > omitted in the first place? Should we be really adding the MSTANDBY_ > flags and fix up the DTS node accordingly? I tried looking through the > git log, and the initial commit itself didn't add the MSTANDBY_ flags > but used the SYSC_HAS_MIDLEMODE. > > Jyri, > Do you know the history? > Sorry. This all has happened before my time. This is all new to me. BR, Jyri > regards > Suman > >> >> Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that >> the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. > > > >> >> Signed-off-by: Tony Lindgren <tony@atomide.com> >> --- >> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >> @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { >> static struct omap_hwmod_class_sysconfig lcdc_sysc = { >> .rev_offs = 0x0, >> .sysc_offs = 0x54, >> - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), >> + .sysc_flags = SYSC_HAS_SIDLEMODE, >> .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), >> .sysc_fields = &omap_hwmod_sysc_type2, >> }; >> >
* Jyri Sarha <jsarha@ti.com> [190813 11:05]: > On 23/07/2019 22:03, Suman Anna wrote: > > + Jyri > > > > On 7/23/19 6:28 AM, Tony Lindgren wrote: > >> We currently get a warning for lcdc because of a difference > >> with dts provided configuration compared to the legacy platform > >> data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in > >> the platform data without configuring the modes. > > > > Hi Tony, > > While I understand that you are trying to match the DT data with the > > existing legacy data, do you know if there was a reason why this was > > omitted in the first place? Should we be really adding the MSTANDBY_ > > flags and fix up the DTS node accordingly? I tried looking through the > > git log, and the initial commit itself didn't add the MSTANDBY_ flags > > but used the SYSC_HAS_MIDLEMODE. > > > > Jyri, > > Do you know the history? > > > > Sorry. This all has happened before my time. This is all new to me. Oh OK. Well if possible, could you please check if the following patch behaves with v5.2 for you for LCDC? I only have rack access to a beaglebone with hdmi right now. TRM "Table 13-34. SYSCONFIG Register Field Descriptions" lists both standbymode and idlemode that should be just the sidle and midle registers where midle is currently unconfigured. Regards, Tony 8< --------------------- diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c @@ -255,8 +255,9 @@ static struct omap_hwmod am33xx_gpio0_hwmod = { static struct omap_hwmod_class_sysconfig lcdc_sysc = { .rev_offs = 0x0, .sysc_offs = 0x54, - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), - .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), + .sysc_flags = SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE, + .idlemodes = SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | + MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART, .sysc_fields = &omap_hwmod_sysc_type2, };
diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { static struct omap_hwmod_class_sysconfig lcdc_sysc = { .rev_offs = 0x0, .sysc_offs = 0x54, - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), + .sysc_flags = SYSC_HAS_SIDLEMODE, .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), .sysc_fields = &omap_hwmod_sysc_type2, };
We currently get a warning for lcdc because of a difference with dts provided configuration compared to the legacy platform data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in the platform data without configuring the modes. Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. Signed-off-by: Tony Lindgren <tony@atomide.com> --- arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)