| Message ID | b29844e0-4dee-a6a5-913c-59c40f8ab77a@xs4all.nl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | am437x: remove unused struct vpfe_pixel_format | expand |
Hi Hans, Thank you for the patch. On Tue, Jul 23, 2019 at 1:59 PM Hans Verkuil <hverkuil@xs4all.nl> wrote: > > struct vpfe_pixel_format was defined, but never used. Remove it. > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> > --- > diff --git a/drivers/media/platform/am437x/am437x-vpfe.h b/drivers/media/platform/am437x/am437x-vpfe.h > index 17d7aa426788..4678285f34c6 100644 > --- a/drivers/media/platform/am437x/am437x-vpfe.h > +++ b/drivers/media/platform/am437x/am437x-vpfe.h Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> Regards, --Prabhakar Lad > @@ -65,12 +65,6 @@ struct vpfe_hw_if_param { > #define VPFE_MAX_SUBDEV 1 > #define VPFE_MAX_INPUTS 1 > > -struct vpfe_pixel_format { > - struct v4l2_fmtdesc fmtdesc; > - /* bytes per pixel */ > - int bpp; > -}; > - > struct vpfe_std_info { > int active_pixels; > int active_lines;
Hans Verkuil <hverkuil@xs4all.nl> wrote on Tue [2019-Jul-23 14:59:47 +0200]: > struct vpfe_pixel_format was defined, but never used. Remove it. > > Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> > --- > diff --git a/drivers/media/platform/am437x/am437x-vpfe.h b/drivers/media/platform/am437x/am437x-vpfe.h > index 17d7aa426788..4678285f34c6 100644 > --- a/drivers/media/platform/am437x/am437x-vpfe.h > +++ b/drivers/media/platform/am437x/am437x-vpfe.h > @@ -65,12 +65,6 @@ struct vpfe_hw_if_param { > #define VPFE_MAX_SUBDEV 1 > #define VPFE_MAX_INPUTS 1 > > -struct vpfe_pixel_format { > - struct v4l2_fmtdesc fmtdesc; > - /* bytes per pixel */ > - int bpp; > -}; > - Looks fine to me. Acked-by: Benoit Parrot <bparrot@ti.com> > struct vpfe_std_info { > int active_pixels; > int active_lines;
diff --git a/drivers/media/platform/am437x/am437x-vpfe.h b/drivers/media/platform/am437x/am437x-vpfe.h index 17d7aa426788..4678285f34c6 100644 --- a/drivers/media/platform/am437x/am437x-vpfe.h +++ b/drivers/media/platform/am437x/am437x-vpfe.h @@ -65,12 +65,6 @@ struct vpfe_hw_if_param { #define VPFE_MAX_SUBDEV 1 #define VPFE_MAX_INPUTS 1 -struct vpfe_pixel_format { - struct v4l2_fmtdesc fmtdesc; - /* bytes per pixel */ - int bpp; -}; - struct vpfe_std_info { int active_pixels; int active_lines;
struct vpfe_pixel_format was defined, but never used. Remove it. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> ---