diff mbox series

i3c: master: Add of_node_put() before return

Message ID 20190723103725.7950-1-nishkadg.linux@gmail.com (mailing list archive)
State Mainlined
Commit 91227632fc7a047965dcc41da89a40dc982caae8
Headers show
Series i3c: master: Add of_node_put() before return | expand

Commit Message

Nishka Dasgupta July 23, 2019, 10:37 a.m. UTC 
Each iteration of for_each_available_childe_of_node puts the previous
node, but in the case of a return from the middle of the loop, there
is no put, thus causing a memory leak. Add an of_node_put before the
return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
 drivers/i3c/master.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index d6f8b038a896..116d4e7ef25c 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2093,8 +2093,10 @@  static int of_populate_i3c_bus(struct i3c_master_controller *master)
 
 	for_each_available_child_of_node(i3cbus_np, node) {
 		ret = of_i3c_master_add_dev(master, node);
-		if (ret)
+		if (ret) {
+			of_node_put(node);
 			return ret;
+		}
 	}
 
 	/*