| Message ID | 20190724072008.6272-1-guillaume.gardet@free.fr (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm: dts: exynos: Add GPU/Mali T604 node to exynos5250 | expand |
Hi, Thanks for the patch. On Wed, Jul 24, 2019 at 09:20:08AM +0200, Guillaume GARDET wrote: > From: Guillaume GARDET <guillaume.gardet@arm.com> > > Add nodes for GPU (Mali T604) to Exynos5250, disabled by default. Why disabled? If tested I would expect it to be enabled at least on tested platforms. > Tested with kmscube on Chromebook snow. > > Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com> > > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > > --- > arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index d5e0392b409e..5ce4b2853cf2 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -1097,6 +1097,53 @@ > */ > clock-frequency = <24000000>; > }; > + > + mali: gpu@0x11800000 { 1. Put the node under /soc (as recently pointed out by Marek Szyprowski) in an address-sorted mode... if possible (nodes are mixed so find some reasonable place based on address_. 2. Fix errors from: make dtbs W=1 > + compatible = "samsung,exynos5250-mali", "arm,mali-t604"; You also need to update the bindings. > + reg = <0x11800000 0x5000>; > + interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>, Please run checkpatch and fix the errors. > + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "job", "mmu", "gpu"; > + clocks = <&clock CLK_G3D>; > + clock-names = "g3d"; > + operating-points-v2 = <&gpu_opp_table>; > + power-domains = <&pd_g3d>; > + status = "disabled"; > + }; > + > + gpu_opp_table: gpu-opp-table { GPU opp table as subnode of Mali node. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index d5e0392b409e..5ce4b2853cf2 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -1097,6 +1097,53 @@ */ clock-frequency = <24000000>; }; + + mali: gpu@0x11800000 { + compatible = "samsung,exynos5250-mali", "arm,mali-t604"; + reg = <0x11800000 0x5000>; + interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "job", "mmu", "gpu"; + clocks = <&clock CLK_G3D>; + clock-names = "g3d"; + operating-points-v2 = <&gpu_opp_table>; + power-domains = <&pd_g3d>; + status = "disabled"; + }; + + gpu_opp_table: gpu-opp-table { + compatible = "operating-points-v2"; + + opp-100000000 { + opp-hz = /bits/ 64 <100000000>; + opp-microvolt = <925000>; + }; + opp-160000000 { + opp-hz = /bits/ 64 <160000000>; + opp-microvolt = <925000>; + }; + opp-266000000 { + opp-hz = /bits/ 64 <266000000>; + opp-microvolt = <1025000>; + }; + opp-350000000 { + opp-hz = /bits/ 64 <350000000>; + opp-microvolt = <1075000>; + }; + opp-400000000 { + opp-hz = /bits/ 64 <400000000>; + opp-microvolt = <1125000>; + }; + opp-450000000 { + opp-hz = /bits/ 64 <450000000>; + opp-microvolt = <1150000>; + }; + opp-533000000 { + opp-hz = /bits/ 64 <533000000>; + opp-microvolt = <1250000>; + }; + }; }; &dp {