| Message ID | 20190724080110.6952-1-shenran268@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/1] drivers/hwmon/acpi_power_meter.c: Change log level | expand |
On Wed, Jul 24, 2019 at 11:01:10AM +0300, Wang Shenran wrote: > At boot time, the acpi_power_meter driver logs the following error level > message: "Ignoring unsafe software power cap". Having read about it from > a few sources, it seems that the error message can be quite misleading. > > While the message can imply that Linux is ignoring the fact that the > system is operating in potentially dangerous conditions, the truth is > the driver found an ACPI_PMC object that supports software power > capping. The driver simply decides not to use it, perhaps because it > doesn't support the object. > > The best solution is probably changing the log level from error to warning. > All sources I have found, regarding the error, have downplayed its > significance. There is not much of a reason for it to be on error level, > while causing potential confusions or misinterpretations. > > Signed-off-by: Wang Shenran <shenran268@gmail.com> Applied to hwmon-next. Thanks, Guenter > --- > drivers/hwmon/acpi_power_meter.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c > index 6ba1a08253f0..4cf25458f0b9 100644 > --- a/drivers/hwmon/acpi_power_meter.c > +++ b/drivers/hwmon/acpi_power_meter.c > @@ -681,8 +681,8 @@ static int setup_attrs(struct acpi_power_meter_resource *resource) > > if (resource->caps.flags & POWER_METER_CAN_CAP) { > if (!can_cap_in_hardware()) { > - dev_err(&resource->acpi_dev->dev, > - "Ignoring unsafe software power cap!\n"); > + dev_warn(&resource->acpi_dev->dev, > + "Ignoring unsafe software power cap!\n"); > goto skip_unsafe_cap; > } >
Great, thanks! Shenran On Wed, Jul 24, 2019 at 5:07 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On Wed, Jul 24, 2019 at 11:01:10AM +0300, Wang Shenran wrote: > > At boot time, the acpi_power_meter driver logs the following error level > > message: "Ignoring unsafe software power cap". Having read about it from > > a few sources, it seems that the error message can be quite misleading. > > > > While the message can imply that Linux is ignoring the fact that the > > system is operating in potentially dangerous conditions, the truth is > > the driver found an ACPI_PMC object that supports software power > > capping. The driver simply decides not to use it, perhaps because it > > doesn't support the object. > > > > The best solution is probably changing the log level from error to warning. > > All sources I have found, regarding the error, have downplayed its > > significance. There is not much of a reason for it to be on error level, > > while causing potential confusions or misinterpretations. > > > > Signed-off-by: Wang Shenran <shenran268@gmail.com> > > Applied to hwmon-next. > > Thanks, > Guenter > > > --- > > drivers/hwmon/acpi_power_meter.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c > > index 6ba1a08253f0..4cf25458f0b9 100644 > > --- a/drivers/hwmon/acpi_power_meter.c > > +++ b/drivers/hwmon/acpi_power_meter.c > > @@ -681,8 +681,8 @@ static int setup_attrs(struct acpi_power_meter_resource *resource) > > > > if (resource->caps.flags & POWER_METER_CAN_CAP) { > > if (!can_cap_in_hardware()) { > > - dev_err(&resource->acpi_dev->dev, > > - "Ignoring unsafe software power cap!\n"); > > + dev_warn(&resource->acpi_dev->dev, > > + "Ignoring unsafe software power cap!\n"); > > goto skip_unsafe_cap; > > } > >
diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c index 6ba1a08253f0..4cf25458f0b9 100644 --- a/drivers/hwmon/acpi_power_meter.c +++ b/drivers/hwmon/acpi_power_meter.c @@ -681,8 +681,8 @@ static int setup_attrs(struct acpi_power_meter_resource *resource) if (resource->caps.flags & POWER_METER_CAN_CAP) { if (!can_cap_in_hardware()) { - dev_err(&resource->acpi_dev->dev, - "Ignoring unsafe software power cap!\n"); + dev_warn(&resource->acpi_dev->dev, + "Ignoring unsafe software power cap!\n"); goto skip_unsafe_cap; }
At boot time, the acpi_power_meter driver logs the following error level message: "Ignoring unsafe software power cap". Having read about it from a few sources, it seems that the error message can be quite misleading. While the message can imply that Linux is ignoring the fact that the system is operating in potentially dangerous conditions, the truth is the driver found an ACPI_PMC object that supports software power capping. The driver simply decides not to use it, perhaps because it doesn't support the object. The best solution is probably changing the log level from error to warning. All sources I have found, regarding the error, have downplayed its significance. There is not much of a reason for it to be on error level, while causing potential confusions or misinterpretations. Signed-off-by: Wang Shenran <shenran268@gmail.com> --- drivers/hwmon/acpi_power_meter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)