[2/5] drm/i915: Avoid one round-tip through global i915 when getting to gt
diff mbox series

Message ID 20190724100716.10731-2-tvrtko.ursulin@linux.intel.com
State New
Headers show
Series
  • [1/5] drm/i915: Split i915_gem_init_hw into GT and i915 parts
Related show

Commit Message

Tvrtko Ursulin July 24, 2019, 10:07 a.m. UTC
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Go to gt->active_rings via timeline instead of global i915 for more
logical organization.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/i915_request.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Wilson July 24, 2019, 10:14 a.m. UTC | #1
Quoting Tvrtko Ursulin (2019-07-24 11:07:13)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Go to gt->active_rings via timeline instead of global i915 for more
> logical organization.

Grr, I've been sending patches to kill this for over 6 months.
-Chris
Tvrtko Ursulin July 24, 2019, 10:32 a.m. UTC | #2
On 24/07/2019 11:14, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-07-24 11:07:13)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Go to gt->active_rings via timeline instead of global i915 for more
>> logical organization.
> 
> Grr, I've been sending patches to kill this for over 6 months.

As part of something bigger I bet? :)

Regards,

Tvrtko

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 8ac7d14ec8c9..9d4b4f2d1b51 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -1182,7 +1182,7 @@  struct i915_request *__i915_request_commit(struct i915_request *rq)
 
 	list_add_tail(&rq->ring_link, &ring->request_list);
 	if (list_is_first(&rq->ring_link, &ring->request_list))
-		list_add(&ring->active_link, &rq->i915->gt.active_rings);
+		list_add(&ring->active_link, &ring->timeline->gt->active_rings);
 	rq->emitted_jiffies = jiffies;
 
 	/*