| Message ID | 62d9c73aafcdc171edcd9e03fa81f451a42d5227.1563995813.git.leonard.crestez@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: imx8mm: Fix boot hang at clk init | expand |
On 19-07-24 22:17:15, Leonard Crestez wrote: > The assigned-clock-rates property is incorrect (shorter than > assigned-clocks) and boot hangs becuause incorrect rates are assigned. > > Fix by inserting another <0> > > Fixes: df1703896a17 ("arm64: dts: imx8mm: Init rates and parents configs for clocks") > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > --- > Found in next-20190724 because that's when df1703896a17 was included. > Perhaps this should be squashed? > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index c9a7c0054c5c..8737f833cf9c 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -461,10 +461,11 @@ > <&clk IMX8MM_SYS_PLL3>, > <&clk IMX8MM_VIDEO_PLL1>; > assigned-clock-parents = <&clk IMX8MM_SYS_PLL3_OUT>, > <&clk IMX8MM_SYS_PLL1_800M>; > assigned-clock-rates = <0>, > + <0>, In our tree we have this in the clock provider: clk_set_rate(clks[IMX8MM_CLK_AUDIO_AHB], 400000000); clk_set_rate(clks[IMX8MM_CLK_IPG_AUDIO_ROOT], 400000000); So I guess instead of the newly added <0> you'll have to put <400000000> which would be the rate for IMX8MM_CLK_IPG_AUDIO_ROOT. > <400000000>, > <750000000>, > <594000000>; > }; > > -- > 2.17.1 >
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi index c9a7c0054c5c..8737f833cf9c 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi @@ -461,10 +461,11 @@ <&clk IMX8MM_SYS_PLL3>, <&clk IMX8MM_VIDEO_PLL1>; assigned-clock-parents = <&clk IMX8MM_SYS_PLL3_OUT>, <&clk IMX8MM_SYS_PLL1_800M>; assigned-clock-rates = <0>, + <0>, <400000000>, <750000000>, <594000000>; };
The assigned-clock-rates property is incorrect (shorter than assigned-clocks) and boot hangs becuause incorrect rates are assigned. Fix by inserting another <0> Fixes: df1703896a17 ("arm64: dts: imx8mm: Init rates and parents configs for clocks") Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> --- Found in next-20190724 because that's when df1703896a17 was included. Perhaps this should be squashed?