| Message ID | 20190725020551.27034-1-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: clock: imx8mn: Fix tab indentation for yaml file | expand |
Quoting Anson.Huang@nxp.com (2019-07-24 19:05:51) > From: Anson Huang <Anson.Huang@nxp.com> > > YAML file can NOT contain tab as indentation, fix it. > Would be nice if checkpatch could check for this. > Fixes: 6d6062553e3d ("dt-bindings: imx: Add clock binding doc for i.MX8MN") > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Acked-by: Stephen Boyd <sboyd@kernel.org>
On Thu, Jul 25, 2019 at 3:06 PM Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Anson.Huang@nxp.com (2019-07-24 19:05:51) > > From: Anson Huang <Anson.Huang@nxp.com> > > > > YAML file can NOT contain tab as indentation, fix it. > > > > Would be nice if checkpatch could check for this. Would be nice if folks just ran 'make dt_binding_check'. :) It wouldn't be hard to add a tab check to checkpatch, but that's just one potential problem. Rob
On Thu, Jul 25, 2019 at 10:05:51AM +0800, Anson.Huang@nxp.com wrote: > From: Anson Huang <Anson.Huang@nxp.com> > > YAML file can NOT contain tab as indentation, fix it. > > Fixes: 6d6062553e3d ("dt-bindings: imx: Add clock binding doc for i.MX8MN") > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> I squashed it into the original commit. Shawn
Quoting Rob Herring (2019-07-25 14:37:24) > On Thu, Jul 25, 2019 at 3:06 PM Stephen Boyd <sboyd@kernel.org> wrote: > > > > Quoting Anson.Huang@nxp.com (2019-07-24 19:05:51) > > > From: Anson Huang <Anson.Huang@nxp.com> > > > > > > YAML file can NOT contain tab as indentation, fix it. > > > > > > > Would be nice if checkpatch could check for this. > > Would be nice if folks just ran 'make dt_binding_check'. :) It > wouldn't be hard to add a tab check to checkpatch, but that's just one > potential problem. > Cool, thanks for the pointer. Seems I forgot :) Here's a patch to improve the documentation and make help to answer questions I had about how to work this into my workflow. diff --git a/Documentation/devicetree/writing-schema.md b/Documentation/devicetree/writing-schema.md index dc032db36262..17ad67887fde 100644 --- a/Documentation/devicetree/writing-schema.md +++ b/Documentation/devicetree/writing-schema.md @@ -120,6 +120,7 @@ This will first run the `dt_binding_check` which generates the processed schema. It is also possible to run checks with a single schema file by setting the 'DT_SCHEMA_FILES' variable to a specific schema file. +`make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/trivial-devices.yaml` `make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/trivial-devices.yaml` diff --git a/Makefile b/Makefile index 9be5834073f8..96bb28aa1c46 100644 --- a/Makefile +++ b/Makefile @@ -1503,8 +1503,10 @@ help: @echo '' @$(if $(dtstree), \ echo 'Devicetree:'; \ - echo '* dtbs - Build device tree blobs for enabled boards'; \ - echo ' dtbs_install - Install dtbs to $(INSTALL_DTBS_PATH)'; \ + echo '* dtbs - Build device tree blobs for enabled boards'; \ + echo ' dtbs_install - Install dtbs to $(INSTALL_DTBS_PATH)'; \ + echo ' dt_binding_check - Validate device tree binding documents'; \ + echo ' dtbs_check - Validate device tree source files'; \ echo '') @echo 'Userspace tools targets:'
diff --git a/Documentation/devicetree/bindings/clock/imx8mn-clock.yaml b/Documentation/devicetree/bindings/clock/imx8mn-clock.yaml index 454c5b4..622f365 100644 --- a/Documentation/devicetree/bindings/clock/imx8mn-clock.yaml +++ b/Documentation/devicetree/bindings/clock/imx8mn-clock.yaml @@ -71,7 +71,7 @@ examples: compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <32768>; - clock-output-names = "osc_32k"; + clock-output-names = "osc_32k"; }; osc_24m: clock-osc-24m {